feat(observability): add MeshGateway dashboard #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
feat/gateway_dashboard
branch
3 times, most recently
from
aee5782 to
08e8417
Compare
michaelbeaumont
force-pushed
the
feat/gateway_dashboard
branch
from
08e8417 to
6884dcb
Compare
This simplifies the dashboard where otherwise we have to exclude these clusters in every Prometheus query. Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
feat/gateway_dashboard
branch
from
6884dcb to
2b26373
Compare
|
I found one small bug. If there are no MeshGateway in the mesh, then the dashboard takes into account all dpps Other than that I could not get to work Kubernetes tab, but so is for Kuma Service. |
Signed-off-by: Mike Beaumont <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4555 +/- ##
==========================================
+ Coverage 47.06% 47.09% +0.03%
==========================================
Files 676 676
Lines 45089 45153 +64
==========================================
+ Hits 21219 21266 +47
- Misses 22007 22017 +10
- Partials 1863 1870 +7
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Jul 18, 2022
|
I'm not super happy with the "don't forget to check the empty string" option but I can't find any Prometheus/Grafana tricks to handle this otherwise |
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#3906
Based off the existing Kuma Service dashboard: