-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): helm chart improvements #4337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a change to how affinty is defined so it is more flexible and can be removed entirely if desired. Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
This was tricky, because we had to get rid of the enabled flag in order to maintain backwards compatibility. Because in the past, we only turned on the kds cert checking code if a name was set, but now we want to also turn it on if no name is set but create is true. Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Michael Younkin <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
…t-fixes Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
jakubdyszkiewicz
approved these changes
May 24, 2022
app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
Show resolved
Hide resolved
lahabana
reviewed
May 24, 2022
Signed-off-by: Bart Smykla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
+ Coverage 55.38% 55.41% +0.02%
==========================================
Files 941 941
Lines 57125 57125
==========================================
+ Hits 31641 31657 +16
+ Misses 22974 22968 -6
+ Partials 2510 2500 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@bartsmykla: As we have a code freeze today I decided to take over the PR and address some of the comments from @jakubdyszkiewicz to make this PR in. The only change we removed, as we were not sure if it was the best solution (additional secrets creations) in current form, but we are definitely open for the discussion @michaelgoodrx
Original PR:
When using the Kuma helm chart at GoodRx, we had to make some tweaks to improve availability and integrate with our deployment and monitoring systems. These changes should all be backwards compatible and useful for the community at large. I realize we didn't discuss any of this with the maintainers beforehand. If you choose not to accept, we will maintain these changes in our own fork.
Full changelog
Issues resolved
Supersedes #4220
Documentation
n/a
Testing
I've tested these changes manually but I doubt I have tested every possible configuration.
Backwards compatibility
It should be backwards compatible, but others should verify, because this is very difficult to test. :)