feat(kuma-cp): validate DP compat on kuma backend #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4236 +/- ##
==========================================
- Coverage 55.65% 55.63% -0.03%
==========================================
Files 933 934 +1
Lines 56257 56288 +31
==========================================
+ Hits 31312 31315 +3
- Misses 22457 22481 +24
- Partials 2488 2492 +4
Continue to review full report at Codecov.
|
lahabana
reviewed
May 2, 2022
|
/format |
michaelbeaumont
approved these changes
May 3, 2022
parkanzky
force-pushed
the
feat/dp-compat-insight
branch
from
1f5d4cd to
f7178d9
Compare
Signed-off-by: Paul Parkanzky <[email protected]>
fix(kuma-cp): simplify min version check Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]>
parkanzky
force-pushed
the
feat/dp-compat-insight
branch
from
f7178d9 to
f4cc0cc
Compare
Signed-off-by: Paul Parkanzky <[email protected]>
lukidzi
pushed a commit
that referenced
this pull request
May 11, 2022
* feat(kuma-cp): validate DP compat on kuma backend Signed-off-by: Paul Parkanzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Parkanzky [email protected]
Summary
Kuma-cp side validation of Kuma DP and Zone CP versions. Result stored as boolean within DataplaneInsight and ZoneInsight. Will require a GUI change to consume the bool.
Need to decide if this should be backported to stable.
Full changelog
Issues resolved
Fix #4203
Documentation
Testing
Backwards compatibility
UPGRADE.mdwith any steps users will need to take when upgrading.backport-to-stablelabel if the code follows our backporting policy