-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): add latest version to compat matrix #4232
Conversation
Signed-off-by: Paul Parkanzky <[email protected]>
69a2cb5
to
ce39fde
Compare
Signed-off-by: Paul Parkanzky <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4232 +/- ##
==========================================
- Coverage 55.64% 55.62% -0.02%
==========================================
Files 933 933
Lines 56251 56251
==========================================
- Hits 31303 31292 -11
- Misses 22461 22469 +8
- Partials 2487 2490 +3
Continue to review full report at Codecov.
|
I'm a little confused I thought this was not in use anymore why is this still in the code base? |
@lahabana I also thought it was not used anymore. However, the GUI code still pulls it down and checks the version of the DP against the list, which caused this bug when the list was not updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if anyone was really quite aware we were serving the matrix from the API server...
Untangle comment from specific version. Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]>
3d85162
to
dfc354f
Compare
Is the right fix to have this shipped only in release-1.6 and remove it in master then? |
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]> (cherry picked from commit 1cde04b)
I think we should remove it as part of the task that replaces it. |
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]> (cherry picked from commit 1cde04b) Signed-off-by: Paul Parkanzky <[email protected]>
@mergify backport release-1.6 |
✅ Backports have been created
|
@mergify backport release-1.6 |
✅ Backports have been created
|
@mergify backport tests/test-mergify-dco |
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]> (cherry picked from commit 1cde04b)
✅ Backports have been created
|
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]> (cherry picked from commit 1cde04b) Signed-off-by: Paul Parkanzky <[email protected]>
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]> (cherry picked from commit 1cde04b) Signed-off-by: Paul Parkanzky <[email protected]> Co-authored-by: Paul A. Parkanzky <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
* fix(kuma-cp): add latest version to compat matrix Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]>
Signed-off-by: Paul Parkanzky [email protected]
Summary
GUI still uses the compatibility matrix to find the latest Kuma DP version. Need to add version so that 1.6.0 does not complain about DP.
Full changelog
Issues resolved
Fix kumahq/kuma-gui#321
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy