Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): add latest version to compat matrix #4232

Merged
merged 3 commits into from
May 4, 2022

Conversation

parkanzky
Copy link
Contributor

Signed-off-by: Paul Parkanzky [email protected]

Summary

GUI still uses the compatibility matrix to find the latest Kuma DP version. Need to add version so that 1.6.0 does not complain about DP.

Full changelog

  • Add latest DP version to compatibility matrix.

Issues resolved

Fix kumahq/kuma-gui#321

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@parkanzky parkanzky requested a review from a team as a code owner May 2, 2022 14:44
@parkanzky parkanzky changed the title fix(kuma-cp): Add latest version to compat matrix fix(kuma-cp): add latest version to compat matrix May 2, 2022
@parkanzky parkanzky force-pushed the fix/kuma-dp-version-check branch from 69a2cb5 to ce39fde Compare May 2, 2022 17:49
Signed-off-by: Paul Parkanzky <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #4232 (dfc354f) into master (22f2093) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
- Coverage   55.64%   55.62%   -0.02%     
==========================================
  Files         933      933              
  Lines       56251    56251              
==========================================
- Hits        31303    31292      -11     
- Misses      22461    22469       +8     
- Partials     2487     2490       +3     
Impacted Files Coverage Δ
pkg/test/grpc/clientstream.go 84.00% <0.00%> (-8.00%) ⬇️
pkg/core/runtime/component/component.go 82.45% <0.00%> (-7.02%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/kds/client/sink.go 54.05% <0.00%> (-5.41%) ⬇️
pkg/defaults/components.go 82.14% <0.00%> (-3.58%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (-2.13%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f2093...dfc354f. Read the comment docs.

@lahabana
Copy link
Contributor

lahabana commented May 3, 2022

I'm a little confused I thought this was not in use anymore why is this still in the code base?

@parkanzky
Copy link
Contributor Author

I'm a little confused I thought this was not in use anymore why is this still in the code base?

@lahabana I also thought it was not used anymore. However, the GUI code still pulls it down and checks the version of the DP against the list, which caused this bug when the list was not updated.

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if anyone was really quite aware we were serving the matrix from the API server...

Untangle comment from specific version.

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
@parkanzky parkanzky force-pushed the fix/kuma-dp-version-check branch from 3d85162 to dfc354f Compare May 3, 2022 17:25
@lahabana
Copy link
Contributor

lahabana commented May 4, 2022

Is the right fix to have this shipped only in release-1.6 and remove it in master then?

@parkanzky parkanzky merged commit 1cde04b into master May 4, 2022
@parkanzky parkanzky deleted the fix/kuma-dp-version-check branch May 4, 2022 19:03
mergify bot pushed a commit that referenced this pull request May 4, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
(cherry picked from commit 1cde04b)
@parkanzky
Copy link
Contributor Author

Is the right fix to have this shipped only in release-1.6 and remove it in master then?

I think we should remove it as part of the task that replaces it.

parkanzky added a commit that referenced this pull request May 5, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
(cherry picked from commit 1cde04b)
Signed-off-by: Paul Parkanzky <[email protected]>
@parkanzky
Copy link
Contributor Author

@mergify backport release-1.6

@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

backport release-1.6

✅ Backports have been created

@parkanzky
Copy link
Contributor Author

@mergify backport release-1.6

@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

backport release-1.6

✅ Backports have been created

@parkanzky
Copy link
Contributor Author

@mergify backport tests/test-mergify-dco

mergify bot pushed a commit that referenced this pull request May 5, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
(cherry picked from commit 1cde04b)
@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

backport tests/test-mergify-dco

✅ Backports have been created

parkanzky added a commit that referenced this pull request May 5, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
(cherry picked from commit 1cde04b)
Signed-off-by: Paul Parkanzky <[email protected]>
mergify bot added a commit that referenced this pull request May 5, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
(cherry picked from commit 1cde04b)
Signed-off-by: Paul Parkanzky <[email protected]>

Co-authored-by: Paul A. Parkanzky <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
lukidzi pushed a commit that referenced this pull request May 11, 2022
* fix(kuma-cp): add latest version to compat matrix

Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Paul Parkanzky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported version of Kuma DP (1.6.0)
4 participants