Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): added arm build and release pipline #4231

Merged
merged 6 commits into from
May 10, 2022
Merged

feat(*): added arm build and release pipline #4231

merged 6 commits into from
May 10, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 2, 2022

Summary

Added ARM64 build/test/release pipeline. Skipped tests that are not working on ARM64 yet (KIC/Compatibility/Hybrid)

Full changelog

  • [Added pipeline for test/build/release arm64]
  • [Changed script to support arm64 build/release]
  • [Updated release script to publish docker manifest and release one tag for diff arch]
  • [Added custom kubectl docker with bash access]

Issues resolved

Part of Fix #237

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@lukidzi lukidzi requested a review from a team as a code owner May 2, 2022 13:05
@codecov-commenter
Copy link

Codecov Report

Merging #4231 (5bbf406) into master (22f2093) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
- Coverage   55.64%   55.64%   -0.01%     
==========================================
  Files         933      933              
  Lines       56251    56251              
==========================================
- Hits        31303    31302       -1     
  Misses      22461    22461              
- Partials     2487     2488       +1     
Impacted Files Coverage Δ
test/framework/deployments/tracing/universal.go 0.00% <0.00%> (ø)
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/defaults/components.go 82.14% <0.00%> (-3.58%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.80% <0.00%> (+1.14%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f2093...5bbf406. Read the comment docs.

@slonka
Copy link
Contributor

slonka commented May 9, 2022

Looks reasonable 👍

@lahabana
Copy link
Contributor

Sweet! Merge it and I'll rebase #4181 on this :)

@lukidzi lukidzi merged commit e30f23f into master May 10, 2022
@lukidzi lukidzi deleted the feat/arm_e2e branch May 10, 2022 11:20
lukidzi added a commit that referenced this pull request May 11, 2022
* feat(*): use image with arm support and update ports
upgrade jaeger all in one to support arm
added workflow for arm64
added kubectl image which has bash

Signed-off-by: Łukasz Dziedziak <[email protected]>
slonka pushed a commit that referenced this pull request May 12, 2022
* feat(*): use image with arm support and update ports
upgrade jaeger all in one to support arm
added workflow for arm64
added kubectl image which has bash

Signed-off-by: Łukasz Dziedziak <[email protected]>
Signed-off-by: slonka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM64 (AARCH64) Support (Both Docker and Linux binaries)
5 participants