fix(gateway): ignore non TCP protocol for provided gateway #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has always been a tricky bit for the provided gateway with often
the dataplane generation failing with:
```
controllers.Pod unable to create/update Dataplane {"pod": "kong-mesh-system/kong-gateway-kong-9k8zc", "operationResult": "unchanged", "error": "admission webhook \"validator.kuma-admission.kuma.io\" denied the request: spec.networking.gateway.tags[\"kuma.io/protocol\"]: other values than TCP are not allowed"}
```
We now simplify drop and log whenever a protocol is set on a gateway that is
not tcp
Signed-off-by: Charly Molter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4067 +/- ##
=======================================
Coverage 55.83% 55.83%
=======================================
Files 922 922
Lines 55431 55436 +5
=======================================
+ Hits 30948 30955 +7
+ Misses 22031 22028 -3
- Partials 2452 2453 +1
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Mar 29, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Mar 30, 2022
This has always been a tricky bit for the provided gateway with often
the dataplane generation failing with:
```
controllers.Pod unable to create/update Dataplane {"pod": "kong-mesh-system/kong-gateway-kong-9k8zc", "operationResult": "unchanged", "error": "admission webhook \"validator.kuma-admission.kuma.io\" denied the request: spec.networking.gateway.tags[\"kuma.io/protocol\"]: other values than TCP are not allowed"}
```
We now simplify drop and log whenever a protocol is set on a gateway that is
not tcp
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
This has always been a tricky bit for the provided gateway with often
the dataplane generation failing with:
```
controllers.Pod unable to create/update Dataplane {"pod": "kong-mesh-system/kong-gateway-kong-9k8zc", "operationResult": "unchanged", "error": "admission webhook \"validator.kuma-admission.kuma.io\" denied the request: spec.networking.gateway.tags[\"kuma.io/protocol\"]: other values than TCP are not allowed"}
```
We now simplify drop and log whenever a protocol is set on a gateway that is
not tcp
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
This has always been a tricky bit for the provided gateway with often
the dataplane generation failing with:
```
controllers.Pod unable to create/update Dataplane {"pod": "kong-mesh-system/kong-gateway-kong-9k8zc", "operationResult": "unchanged", "error": "admission webhook \"validator.kuma-admission.kuma.io\" denied the request: spec.networking.gateway.tags[\"kuma.io/protocol\"]: other values than TCP are not allowed"}
```
We now simplify drop and log whenever a protocol is set on a gateway that is
not tcp
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has always been a tricky bit for the provided gateway with often
the dataplane generation failing with:
We now simply drop and log whenever a protocol is set on a gateway that is not tcp
Documentation
Testing
Backwards compatibility
UPGRADE.mdwith any steps users will need to take when upgrading.backport-to-stablelabel if the code follows our backporting policy