fix(kuma-cp): gateway reconciliation loops forever #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4034 +/- ##
==========================================
- Coverage 55.98% 55.96% -0.03%
==========================================
Files 919 919
Lines 55267 55285 +18
==========================================
- Hits 30942 30941 -1
- Misses 21875 21893 +18
- Partials 2450 2451 +1
Continue to review full report at Codecov.
|
| @@ -73,11 +75,14 @@ func (r *GatewayInstanceReconciler) Reconcile(ctx context.Context, req kube_ctrl | |||
|
|
|||
| updateStatus(gatewayInstance, svc, deployment) | |||
|
|
|||
| if err := r.Client.Status().Patch(ctx, gatewayInstance, kube_client.MergeFrom(orig)); err != nil { | |||
There was a problem hiding this comment.
I think the right way to handle this is using SetStatusCondition like in the gatewayapi controllers
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Mar 28, 2022
…)" This reverts commit 961ba79.
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Mar 28, 2022
…)" This reverts commit 961ba79. Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Mar 28, 2022
…on (#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Mar 30, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 20, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 20, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
…on (kumahq#4051) * Revert "fix(kuma-cp): gateway reconciliation loops forever (kumahq#4034)" This reverts commit 961ba79. * fix(gateway): fix status updating in MeshGatewayInstance reconciliation * chore(gateway): add back verbose log for reconcile begin Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Sally Blich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gateway API reconciliation was stuck in a loop (reconciling forever) because GatewayInstance was constantly updated.
We should only update Status of objects if there is any change to the status.
Issues resolved
No issues reported
Documentation
- [ ] Link to the website documentation PRTesting
Backwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy