Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): validate GatewayAPI with multizone #4022

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Mar 21, 2022

Summary

Provide validation that Gateway API cannot be used with Zone and Global CP.
I validate only GatewayClass, otherwise, it's kind of hard to figure out if Gateway or GatewayRoute is used only with Kuma or not. GatewayClass is the required resource for Kuma Gateway to work anyways.

Issues resolved

Fix #3905

Documentation

There is already docs that you cannot use GatewayAPI with mutlizone

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Changelog: feat(gateway): release K8s GatewayAPI as preview

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner March 21, 2022 12:33
@codecov-commenter
Copy link

Codecov Report

Merging #4022 (b4a6362) into master (a995bb1) will decrease coverage by 0.02%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #4022      +/-   ##
==========================================
- Coverage   56.05%   56.03%   -0.03%     
==========================================
  Files         919      920       +1     
  Lines       55113    55128      +15     
==========================================
- Hits        30895    30891       -4     
- Misses      21774    21789      +15     
- Partials     2444     2448       +4     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/plugin.go 1.08% <0.00%> (+<0.01%) ⬆️
...ime/k8s/webhooks/gatewayapi_multizone_validator.go 37.50% <37.50%> (ø)
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-13.89%) ⬇️
pkg/core/secrets/manager/global_manager.go 39.39% <0.00%> (-3.04%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/plugins/resources/postgres/store.go 74.68% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a995bb1...b4a6362. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 9d85509 into master Mar 28, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/validate-multizone-gatewayapi branch March 28, 2022 16:20
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Mar 30, 2022
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation controller to disallow using GatewayAPI in multizone
4 participants