Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp): use appProtocol by default #4015

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Mar 18, 2022

Summary

See kumahq/kuma-website#731

Issues resolved

No issues reported

Documentation

kumahq/kuma-website#731

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Changelog: chore(k8s): use appProtocol from service by default

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner March 18, 2022 10:14
@codecov-commenter
Copy link

Codecov Report

Merging #4015 (45b98c1) into master (6461cb9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4015      +/-   ##
==========================================
- Coverage   56.06%   56.04%   -0.02%     
==========================================
  Files         919      919              
  Lines       55097    55098       +1     
==========================================
- Hits        30888    30882       -6     
- Misses      21766    21770       +4     
- Partials     2443     2446       +3     
Impacted Files Coverage Δ
...est/framework/deployments/testserver/kubernetes.go 0.00% <0.00%> (ø)
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-13.89%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/core/secrets/manager/global_manager.go 39.39% <0.00%> (-3.04%) ⬇️
pkg/core/resources/model/rest/resource.go 71.60% <0.00%> (-1.24%) ⬇️
pkg/plugins/resources/postgres/store.go 74.68% <0.00%> (-0.43%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.80% <0.00%> (+1.14%) ⬆️
pkg/defaults/components.go 88.88% <0.00%> (+3.70%) ⬆️
pkg/kds/reconcile/reconciler.go 84.61% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6461cb9...45b98c1. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 846f347 into master Mar 18, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/appprotocol-by-defualt branch March 18, 2022 13:12
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Mar 30, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Sally Blich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants