fix: adds parsing of unknown action type for API backwards compatibility #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against f1246d3 |
kodiakhq bot
pushed a commit
to kula-app/OnLaunch
that referenced
this pull request
Jul 29, 2024
This pull request introduces the messages endpoint v0.2 which will replace the current v0.1 used by client libraries. The main necessity of this pull request is caused due to a DTO decoding issue in https://github.com/kula-app/OnLaunch-iOS-Client, where I forgot to implement backwards compatibility when parsing the `ActionType`. The issue in the client will be fixed with kula-app/OnLaunch-iOS-Client#53 but due to apps shipped with the latest release of the iOS client, we are bumping the API endpoint version too, and filter out any newly introduced action types. This will also require updates to the Android and Flutter clients, but as new action types require changes in the clients anyways, there won't be an issue until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.