Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Extra.ignore to Extra.allow #14

Open
mike-oakley opened this issue May 13, 2022 · 0 comments
Open

Change Extra.ignore to Extra.allow #14

mike-oakley opened this issue May 13, 2022 · 0 comments

Comments

@mike-oakley
Copy link

mike-oakley commented May 13, 2022

Hey there!

I think this library would be a lot more flexible if the models allowed extra fields to be set so arbitrary extensions can be used. This will make it a lot more useful for downstream libraries such as client generators.

I noticed in #9 you mentioned that you preferred to disallow this to show the library doesn't support this, but as far as I can tell, allowing the extensions will not affect the way this library works. Granted, extensions will not have validation or typing, but as long as we add a disclaimer in the readme I don't see why these shouldn't be allowed?

Thanks 😄

JensHeinrich pushed a commit to JensHeinrich/openapi-schema-pydantic that referenced this issue Feb 16, 2023
This enables setting the extras option on a global scale.
This enables the usecase of kuimono#14 while still being in the spirit of kuimono#9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant