Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropdownMenuButton): ボタンリストの装飾適用条件を緩和 #5154

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(DropdownMenuButton): ボタンリストの装飾適用条件を緩和 #5154

merged 1 commit into from
Dec 5, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Nov 29, 2024 •
edited
Loading

関連URL

概要

DropdownMenuButton に何らかの形で拡張した Button や AnchorButton を使っていると、装飾があたらない不具合を修正します。

変更内容

  • Button や AnchorButton、RemoteDialogTrigger 以外にも装飾があたるように条件を見直し
  • DropdownMenuGroup には装飾があたらないように修正

確認方法

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 29, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5154

commit: ba0d1e5

@uknmr uknmr force-pushed the fix-DropdownMenuButton branch from 5c0ab5e to ba0d1e5 Compare December 5, 2024 01:37
@uknmr uknmr marked this pull request as ready for review December 5, 2024 01:45
@uknmr uknmr requested a review from a team as a code owner December 5, 2024 01:45
@uknmr uknmr requested review from oti and nabeliwo and removed request for a team December 5, 2024 01:45
zoshigayan
zoshigayan approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@zoshigayan zoshigayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

元々崩れていた環境に入れて動作確認したところ、正しくスタイルが適用されていました！LGTM 🎉

@uknmr uknmr merged commit fe67ad9 into master Dec 5, 2024
13 checks passed
@uknmr uknmr deleted the fix-DropdownMenuButton branch December 5, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoshigayan zoshigayan zoshigayan approved these changes

@TakahiroHimi TakahiroHimi Awaiting requested review from TakahiroHimi

@oti oti Awaiting requested review from oti oti is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@nabeliwo nabeliwo Awaiting requested review from nabeliwo nabeliwo is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uknmr @zoshigayan