feat: Storybookにcontrols addonを追加 #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reg-suit detected visual differences. Check this report, and review them. ⚪⚪⚪⚪⚪⚪⚪⚪ What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
✅ Deploy Preview for smarthr-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
uknmr
requested changes
May 25, 2022
| <WrapLineUp vAlign="center"> | ||
| <Button variant={variant} onClick={action('clicked')}> | ||
| <Cluster> | ||
| <Button variant={'primary'} onClick={action('clicked')}> |
There was a problem hiding this comment.
imo: 他も同じ。
Suggested change
| <Button variant={'primary'} onClick={action('clicked')}> | |
| <Button variant="primary" onClick={action('clicked')}> |
Comment on lines
333
to
336
|
|
||
| > * + * { | ||
| margin-top: 24px; | ||
| } |
There was a problem hiding this comment.
Wrapper は複数コンポーネントを持っていないようだったので、不要に見えました。
* fix: variant propsの記述を修正 * fix: 不要なCSSを削除 * feat: children propsにdefaultValueを追加
|
@uknmr 確認いただきありがとうございます！ |
yuw27b
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Storybook上でpropsを変更しながら挙動を確認できる、controls addonを有効化しました。
What I did
#2443 にてButtonコンポーネントのインターフェースが変わったということなので、まずButtonコンポーネントに試験実装しています。
controlsタブで
variantPropsを動的に変更できるようになるため、表示されるコンポーネントは1つだけにしています。hideNoControlsWarning: trueというオプションを設定する必要があるかもしれません。ReactNodetypeのPropsの場合、controlsにはデフォルトでJSONエディタが表示されてしまい、Storybookがエラーを表示するという問題があるため、childrensuffixprefixの3つについては、{ control: 'text' }を明示的に指定しています。Capture
https://deploy-preview-2488--smarthr-ui.netlify.app/?path=/story/button--button