Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar の年選択ボタンのイベント伝播を阻止する #1803

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Aug 11, 2021

年選択ボタンの位置に依ってイベントが伝播し、予期しない動作を生む。
Event. stopPropagation() でイベントの伝播を阻止する。

@reg-suit
Copy link

reg-suit bot commented Aug 11, 2021

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@uknmr uknmr requested a review from a team as a code owner August 11, 2021 02:09
@uknmr uknmr requested review from yt-ymmt and im36-123 and removed request for a team August 11, 2021 02:09
@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for smarthr-ui ready!

🔨 Explore the source changes: d8315d5

🔍 Inspect the deploy log: https://app.netlify.com/sites/smarthr-ui/deploys/6113316d4f59b20009f14ba5

😎 Browse the preview: https://deploy-preview-1803--smarthr-ui.netlify.app

Copy link
Contributor

@yt-ymmt yt-ymmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@uknmr uknmr merged commit bcf378d into master Aug 18, 2021
@uknmr uknmr deleted the improve-Calendar branch August 18, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants