This repository has been archived by the owner on May 10, 2019. It is now read-only.
Added basic JVM method signature builder. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs a macro to make it actually useful, but at least it's not possible to construct an invalid JVM method signature with it as far as I know.
|
Sorry for the pr spam. It just didn't make sense to include this in the last one. |
|
Awesome, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a macro to make it actually useful, but at least it's not possible to construct an invalid JVM method signature with it as far as I know.
I'm not a macro wizard yet, but at least the hard part is done. If we add
constonto the function it will be able to evaluate it at compile time and hopefully simplify straight down to a string literal in the binary.I hope I didn't put it in a silly location, I haven't dived through all the code to understand it yet. Let me know if there's a better way to do this that follows the conventions for the project.