Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): ppr-indexed-informer should report ready when not leader #72

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Jan 20, 2025

No description provided.

@SOF3 SOF3 requested a review from mingyuanzhu January 20, 2025 08:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.87%. Comparing base (17fa770) to head (39a0fde).

Files with missing lines Patch % Lines
util/podprotector/multi_informer.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   40.92%   40.87%   -0.05%     
==========================================
  Files         101      101              
  Lines        6991     6997       +6     
==========================================
- Hits         2861     2860       -1     
- Misses       3972     3978       +6     
- Partials      158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mingyuanzhu mingyuanzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SOF3 SOF3 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into kubewharf:main with commit fb90474 Jan 20, 2025
4 checks passed
@SOF3 SOF3 deleted the ppr-elector-healthy branch January 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants