-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update testcontainers requirement from 0.20.0 to 0.21.0 #202
Conversation
Updates the requirements on [testcontainers](https://github.com/testcontainers/testcontainers-rs) to permit the latest version. - [Release notes](https://github.com/testcontainers/testcontainers-rs/releases) - [Changelog](https://github.com/testcontainers/testcontainers-rs/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-rs@0.20.0...0.21.0) --- updated-dependencies: - dependency-name: testcontainers dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
By enabling http_wait we pull reqwest. This should mean we drop the dep on aws-lc-rs, which depends on nasm for building on Windows. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
This bump of testcontainers brings At some point on the dependencies, the windows build is using $ cargo tree -i aws-lc-rs
aws-lc-rs v1.8.1
├── rustls v0.23.7
│ ├── bollard v0.17.0
│ │ └── testcontainers v0.21.0
│ │ [dev-dependencies]
│ │ └── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│ ├── hyper-rustls v0.27.2
│ │ ├── bollard v0.17.0 (*)
│ │ └── reqwest v0.12.5
│ │ ├── oci-distribution v0.11.0
│ │ │ ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│ │ │ └── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc)
│ │ │ └── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│ │ ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│ │ └── tough v0.17.1 (https://github.com/flavio/tough.git?branch=kubewarden#4cd7203a)
│ │ └── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc) (*)
│ ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│ ├── reqwest v0.12.5 (*)
│ └── tokio-rustls v0.26.0
│ ├── hyper-rustls v0.27.2 (*)
│ └── reqwest v0.12.5 (*)
└── rustls-webpki v0.102.2
├── rustls v0.23.7 (*)
└── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc) (*) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 40.73% 40.48% -0.25%
==========================================
Files 12 12
Lines 734 741 +7
==========================================
+ Hits 299 300 +1
- Misses 435 441 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looking at the changes in testcontainers, reqwest was made optional under the Tried reenabling it hoping that it would pull a different set of dependencies that wouldn't need |
Seems that what pulls aws-lc-rs on Windows is I don't see a way to deal with this, as it seems that bollard doesn't set It seems that bollard has already done the leg work: fussybeaver/bollard#441 Blocking until a new testcontainers-rs version is released. |
A newer version of testcontainers exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
Superseded by #205. |
Updates the requirements on testcontainers to permit the latest version.
Release notes
Sourced from testcontainers's releases.
Changelog
Sourced from testcontainers's changelog.
... (truncated)
Commits
f8d4a3d
chore: release v0.21.0 (#713)2f05648
fix: don't assume docker host is a url (#709)fe9de51
build(deps): bump zipp from 3.18.1 to 3.19.1 (#696)b380421
chore(deps): bump the bollard group across 1 directory with 2 updates (#710)e354b75
refactor!: putreqwest
behindhttp_wait
feature (#705)eae71c6
chore: release v0.20.1 (#700)64b635d
fix(LoggingConsumer): trim newline char from the mirrored messages (#699)1c83196
feat: support optional prefix forLoggingConsumer
(#698)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)