Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update testcontainers requirement from 0.20.0 to 0.21.0 #202

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 31, 2024

Updates the requirements on testcontainers to permit the latest version.

Release notes

Sourced from testcontainers's releases.

v0.21.0

Details

Bug Fixes

  • Don't assume docker host is a url (#709)

Miscellaneous Tasks

  • Bump the bollard group across 1 directory with 2 updates (#710)

Refactor

  • [❗] Put reqwest behind http_wait feature (#705)
Changelog

Sourced from testcontainers's changelog.

[0.21.0] - 2024-07-30

Details

Bug Fixes

  • Don't assume docker host is a url (#709)

Miscellaneous Tasks

  • Bump the bollard group across 1 directory with 2 updates (#710)

Refactor

  • [❗] Put reqwest behind http_wait feature (#705)

[0.20.1] - 2024-07-18

Details

Bug Fixes

  • Trim newline char from the mirrored messages (#699)

Features

  • Support optional prefix for LoggingConsumer (#698)

[0.20.0] - 2024-07-07

Details

Bug Fixes

  • [❗] Drop Clone impl for ContainerRequest (#680)
  • Exclude image pulling time from startup timeout (#687)
  • Waiting for mutiple messages from the same log frame (#688)
  • Pass correct log-source for stderr wait strategy (#692)

Features

  • Introduce log consumers (#681)
  • Introduce LoggingConsumer based on log crate (#682)
  • [❗] Enhance LogWaitStrategy to wait for message appearance multiple times (#683)
  • [❗] Introduce ExitWaitStrategy (#684)

Miscellaneous Tasks

  • Get rid of outdated variables naming (#679)
  • Relax log level for log producer error (#685)
  • Re-configure blocking runtime (#690)

Performance

  • Avoid spawning log producer without consumers (#689)

Refactor

  • Internal log processing structures (#678)

Styling

  • Apply clippy suggestion (#693)

[0.19.0] - 2024-06-27

Details

Bug Fixes

  • [❗] Use rustls-tls as default for reqwest (#672)

Documentation

... (truncated)

Commits
  • f8d4a3d chore: release v0.21.0 (#713)
  • 2f05648 fix: don't assume docker host is a url (#709)
  • fe9de51 build(deps): bump zipp from 3.18.1 to 3.19.1 (#696)
  • b380421 chore(deps): bump the bollard group across 1 directory with 2 updates (#710)
  • e354b75 refactor!: put reqwest behind http_wait feature (#705)
  • eae71c6 chore: release v0.20.1 (#700)
  • 64b635d fix(LoggingConsumer): trim newline char from the mirrored messages (#699)
  • 1c83196 feat: support optional prefix for LoggingConsumer (#698)
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [testcontainers](https://github.com/testcontainers/testcontainers-rs) to permit the latest version.
- [Release notes](https://github.com/testcontainers/testcontainers-rs/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-rs/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-rs@0.20.0...0.21.0)

---
updated-dependencies:
- dependency-name: testcontainers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 31, 2024 13:52
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Jul 31, 2024
By enabling http_wait we pull reqwest.
This should mean we drop the dep on aws-lc-rs, which depends on
nasm for building on Windows.

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad
Copy link
Member

viccuad commented Aug 2, 2024

This bump of testcontainers brings aws-lc-rs which testcontainers 0.20.0 didn't do. For windows builds, aws-lc-rs depends on nasm which isn't installed, hence, the integration-test failure.

At some point on the dependencies, the windows build is using aws-lc-rs instead of ring.

$ cargo tree -i aws-lc-rs
aws-lc-rs v1.8.1
├── rustls v0.23.7
│   ├── bollard v0.17.0
│   │   └── testcontainers v0.21.0
│   │       [dev-dependencies]
│   │       └── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│   ├── hyper-rustls v0.27.2
│   │   ├── bollard v0.17.0 (*)
│   │   └── reqwest v0.12.5
│   │       ├── oci-distribution v0.11.0
│   │       │   ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│   │       │   └── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc)
│   │       │       └── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│   │       ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│   │       └── tough v0.17.1 (https://github.com/flavio/tough.git?branch=kubewarden#4cd7203a)
│   │           └── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc) (*)
│   ├── policy-fetcher v0.8.8 (/home/vic/suse/kw/policy-fetcher)
│   ├── reqwest v0.12.5 (*)
│   └── tokio-rustls v0.26.0
│       ├── hyper-rustls v0.27.2 (*)
│       └── reqwest v0.12.5 (*)
└── rustls-webpki v0.102.2
    ├── rustls v0.23.7 (*)
    └── sigstore v0.9.0 (https://github.com/flavio/sigstore-rs.git?branch=kubewarden#2872bafc) (*)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.48%. Comparing base (0f31d41) to head (5adbdac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   40.73%   40.48%   -0.25%     
==========================================
  Files          12       12              
  Lines         734      741       +7     
==========================================
+ Hits          299      300       +1     
- Misses        435      441       +6     
Flag Coverage Δ
integration-tests 12.95% <ø> (-0.13%) ⬇️
unit-tests 33.19% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccuad
Copy link
Member

viccuad commented Aug 2, 2024

Looking at the changes in testcontainers, reqwest was made optional under the http_wait feature:
testcontainers/testcontainers-rs@0.20.0...0.21.0#diff-07bcf9c721c85ed46b7541d76e26405de010b6802e1da6c7bca198431eb8d26aR32

Tried reenabling it hoping that it would pull a different set of dependencies that wouldn't need aws-lc-rs and use ring, but the windows build failed still:
https://github.com/kubewarden/policy-fetcher/actions/runs/10181560438/job/28162021632?pr=202#step:5:556

@viccuad
Copy link
Member

viccuad commented Aug 2, 2024

Seems that what pulls aws-lc-rs on Windows is rustls, see: rustls/rustls#1913

I don't see a way to deal with this, as it seems that bollard doesn't set default-features = false, and is consumed by testcontainers-rs.

It seems that bollard has already done the leg work: fussybeaver/bollard#441
And that testcontainers-rs is aware, and will eventually consume it: testcontainers/testcontainers-rs#711

Blocking until a new testcontainers-rs version is released.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 6, 2024

A newer version of testcontainers exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@viccuad
Copy link
Member

viccuad commented Aug 9, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@viccuad
Copy link
Member

viccuad commented Aug 12, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 12, 2024

Superseded by #205.

@dependabot dependabot bot closed this Aug 12, 2024
@dependabot dependabot bot deleted the dependabot/cargo/testcontainers-0.21.0 branch August 12, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant