feat: add Policy getters to Store #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
feat/add_store_policy_getters
branch
from
667a9bc to
3172abf
Compare
flavio
approved these changes
Aug 31, 2023
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
feat/add_store_policy_getters
branch
from
3172abf to
43e53c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
Store::get_policy_by_uriandStore::get_policy_by_sha_prefix.The latter takes a partial sha and returns a policy that matches.
Returns error if multiple results are found.
This behavior is similar to the docker cli, see: https://github.com/docker/engine/blob/8955d8da8951695a98eb7e15bead19d402c6eb27/daemon/container.go#L36
Test
Added integration tests.
Additional Information
Tradeoff