chore: fix clippy warnings

Address clippy warnings

Signed-off-by: Flavio Castelli <[email protected]>

src/callback_handler/mod.rs

@@ -31,7 +31,7 @@ impl CallbackHandler {
     ) -> Result<CallbackHandler> {
         match &cfg.host_capabilities_mode {
             HostCapabilitiesMode::Proxy(proxy_mode) => {
-                new_proxy(&proxy_mode, cfg, kube_client, shutdown_channel).await
+                new_proxy(proxy_mode, cfg, kube_client, shutdown_channel).await
             }
             HostCapabilitiesMode::Direct => {
                 new_transparent(cfg, kube_client, shutdown_channel).await

src/callback_handler/proxy.rs

@@ -169,11 +169,11 @@ impl CallbackHandlerProxy {
         // there's no nice way to handle errors here.
 
         let mut exchanges: VecDeque<Exchange> = if let ProxyMode::Replay { source } = &self.mode {
-            let file = File::open(source).expect(
-                format!("Cannot open host capabilities interactions file {source:?}",).as_str(),
-            );
+            let file = File::open(source).unwrap_or_else(|_| {
+                panic!("Cannot open host capabilities interactions file {source:?}")
+            });
             serde_yaml::from_reader(file)
-                .expect(format!("cannot deserialize contents of {source:?}").as_str())
+                .unwrap_or_else(|_| panic!("cannot deserialize contents of {source:?}"))
         } else {
             // this should never happen
             unreachable!()

src/main.rs

@@ -635,8 +635,7 @@ async fn parse_pull_and_run_settings(matches: &ArgMatches) -> Result<run::PullAn
         let destination = matches
             .get_one::<String>("record-host-capabilities-interactions")
             .map(|destination| PathBuf::from_str(destination).unwrap())
-            .ok_or_else(|| anyhow!("Cannot parse 'record-host-capabilities-interactions' file"))?
-            .to_owned();
+            .ok_or_else(|| anyhow!("Cannot parse 'record-host-capabilities-interactions' file"))?;
 
         // TODO: replace eprintln with info
         // once https://github.com/swsnr/mdcat/issues/242 is fixed
@@ -653,8 +652,7 @@ async fn parse_pull_and_run_settings(matches: &ArgMatches) -> Result<run::PullAn
         let source = matches
             .get_one::<String>("replay-host-capabilities-interactions")
             .map(|source| PathBuf::from_str(source).unwrap())
-            .ok_or_else(|| anyhow!("Cannot parse 'replay-host-capabilities-interaction' file"))?
-            .to_owned();
+            .ok_or_else(|| anyhow!("Cannot parse 'replay-host-capabilities-interaction' file"))?;
 
         // TODO: replace eprintln with info
         // once https://github.com/swsnr/mdcat/issues/242 is fixed

src/run.rs

@@ -95,7 +95,7 @@ pub(crate) async fn prepare_run_env(cfg: &PullAndRunSettings) -> Result<RunEnv>
         oneshot::channel();
 
     let callback_handler =
-        CallbackHandler::new(&cfg, kube_client, callback_handler_shutdown_channel_rx).await?;
+        CallbackHandler::new(cfg, kube_client, callback_handler_shutdown_channel_rx).await?;
 
     let callback_sender_channel = callback_handler.sender_channel();