Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve API documentation #99

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Mar 4, 2024

What this PR does / why we need it:

  • Mentions the ClusterRole that can give users access to the API.
  • Added an example kubectl command to delete ServiceAccount and revoke tokens.

Related: https://issues.redhat.com/browse/CNV-38641

Release note:

Improved API documentation.

- Mention the ClusterRole that can give users access to the API
- Add an example kubectl command to delete ServiceAccount and
  revoke tokens.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 4, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 4, 2024

/cc @0xFelix @jcanocan

@kubevirt-bot kubevirt-bot requested a review from jcanocan March 4, 2024 13:00
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@kubevirt-bot kubevirt-bot merged commit dea4084 into kubevirt:main Mar 4, 2024
3 checks passed
@akrejcir akrejcir deleted the improve-docs branch March 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants