Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run "go mod vendor" and "go mod tidy" #7

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Updated the vendor files.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 22, 2023
Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@lyarwood
Copy link
Member

\n    <v1.VirtualMachineInstancePhase>: Pending\nto equal\n    <v1.VirtualMachineInstancePhase>: Running",
      }
      Assertion in callback at /go/src/github.com/kubevirt/vm-console-proxy/tests/proxy_test.go:312 failed:
      Expected
          <v1.VirtualMachineInstancePhase>: Pending
      to equal
          <v1.VirtualMachineInstancePhase>: Running
  In [BeforeEach] at: /go/src/github.com/kubevirt/vm-console-proxy/tests/proxy_test.go:313 @ 02/22/23 11:11:13.087
------------------------------
Summarizing 3 Failures:
  [FAIL] Token /vnc endpoint with VMI [BeforeEach] should fail if VMI does not exist
  /go/src/github.com/kubevirt/vm-console-proxy/tests/proxy_test.go:313
  [FAIL] Token /vnc endpoint with VMI [BeforeEach] should proxy VNC connection
  /go/src/github.com/kubevirt/vm-console-proxy/tests/proxy_test.go:313
  [FAIL] Token /vnc endpoint with VMI [BeforeEach] should fail if token is expired
  /go/src/github.com/kubevirt/vm-console-proxy/tests/proxy_test.go:313

Eventually(func(g Gomega) {
vmi, err := ApiClient.VirtualMachineInstance(vm.Namespace).Get(vm.Name, &metav1.GetOptions{})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(vmi.Status.Phase).To(Equal(kubevirtcorev1.Running))
}, time.Minute, time.Second).Should(Succeed())

Smells like we need a longer timeout than the current 60 seconds?

@akrejcir
Copy link
Collaborator Author

Yes, I've increased the timeout in the latest revision.

@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

There is a problem with kubevirt on OCP 4.13. It cannot start a VM.
That is not related to this PR.

/override ci/prow/e2e-functests

@kubevirt-bot
Copy link
Contributor

@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-functests

In response to this:

There is a problem with kubevirt on OCP 4.13. It cannot start a VM.
That is not related to this PR.

/override ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

/test ci/prow/e2e-functests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/vm-console-proxy@main

In response to this:

/test ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

@akrejcir: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-functests
  • /test images
  • /test unittests

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @lyarwood

@kubevirt-bot kubevirt-bot requested a review from 0xFelix March 16, 2023 12:45
@0xFelix
Copy link
Member

0xFelix commented Mar 17, 2023

Can you put the changes into two separate commits please?

Updated the vendor files.
Increased time functional tests wait for VM start.

Signed-off-by: Andrej Krejcir <[email protected]>
Copy link
Member

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@kubevirt-bot kubevirt-bot merged commit 98939c6 into kubevirt:main Mar 29, 2023
@akrejcir akrejcir deleted the fix-vendor branch June 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants