-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run "go mod vendor" and "go mod tidy" #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
vm-console-proxy/tests/proxy_test.go Lines 309 to 313 in 0304c6e
Smells like we need a longer timeout than the current 60 seconds? |
Yes, I've increased the timeout in the latest revision. |
/retest |
There is a problem with kubevirt on OCP 4.13. It cannot start a VM. /override ci/prow/e2e-functests |
@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ci/prow/e2e-functests |
@akrejcir: No presubmit jobs available for kubevirt/vm-console-proxy@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@akrejcir: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you put the changes into two separate commits please? |
Updated the vendor files. Increased time functional tests wait for VM start. Signed-off-by: Andrej Krejcir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Updated the vendor files.
Release note: