Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Change link to new asciinema demo #35

Merged
merged 1 commit into from
Oct 19, 2023
Merged

docs: Change link to new asciinema demo #35

merged 1 commit into from
Oct 19, 2023

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Change the link to a new asciinema demo.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Oct 18, 2023
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix

0xFelix
0xFelix reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo says:

The new SrviceAccount has cluster-admin permissions to make

That looks wrong?

@akrejcir
Copy link
Collaborator Author

The demo says:

The new SrviceAccount has cluster-admin permissions to make

That looks wrong?

Good catch, I will rewrite it.

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@akrejcir
Copy link
Collaborator Author

Changed.

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
0xFelix
0xFelix approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

/approve
/lgtm

Thanks!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@kubevirt-bot kubevirt-bot merged commit ea3593e into kubevirt:main Oct 19, 2023
@akrejcir akrejcir deleted the doc-new-demo branch October 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrejcir @kubevirt-bot @0xFelix