Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: API discovery #27

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: API discovery #27

merged 1 commit into from
Aug 29, 2023

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
The API discovery endpoint returns properly filled JSON.

Which issue(s) this PR fixes:
Fixes: https://issues.redhat.com/browse/CNV-32267

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 24, 2023
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @lyarwood

@akrejcir
Copy link
Collaborator Author

I need to do a manual test to make sure the bug is fixed.

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@akrejcir akrejcir marked this pull request as draft August 24, 2023 15:14
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@akrejcir
fix: API discovery
a4efe31 
The API discovery endpoint returns properly filled json.

Signed-off-by: Andrej Krejcir <[email protected]>
@akrejcir
Copy link
Collaborator Author

This is ready for review.

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@akrejcir akrejcir marked this pull request as ready for review August 29, 2023 12:42
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@kubevirt-bot kubevirt-bot requested a review from opokornyy August 29, 2023 12:42
@lyarwood
Copy link
Member

/approve
/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2023
@kubevirt-bot kubevirt-bot merged commit 8be2e83 into kubevirt:main Aug 29, 2023
@akrejcir akrejcir deleted the fix-discovery branch August 29, 2023 14:40
@akrejcir
Copy link
Collaborator Author

/cherry-pick release-v0.3

@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #29

In response to this:

/cherry-pick release-v0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 29, 2023
Merged
@akrejcir akrejcir mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingben codingben Awaiting requested review from codingben

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@lyarwood lyarwood Awaiting requested review from lyarwood

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@lyarwood lyarwood

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrejcir @lyarwood @kubevirt-bot