Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve functional tests #14

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: Improve functional tests #14

merged 1 commit into from
Mar 29, 2023

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:

  • Tests use VMs with generated names, and so they don't need to wait until the previous VM is deleted.
  • Increased timeout for Eventually() statements.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 20, 2023
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix

@kubevirt-bot kubevirt-bot requested a review from 0xFelix March 20, 2023 12:07
@akrejcir
Copy link
Collaborator Author

/retest

0xFelix
0xFelix approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks! Just for context, this does improve overall test performance?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@akrejcir
fix: Improve functional tests
97142f1 
- Tests use VMs with generated names, and so they don't need
to wait until the previous VM is deleted.

- Increased timeout for Eventually() statements.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
0xFelix
0xFelix approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@akrejcir
Copy link
Collaborator Author

Thanks! Just for context, this does improve overall test performance?

It could, because the tests don't wait until VMs are deleted. But I didn't check the timing.

@akrejcir
Copy link
Collaborator Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2023
@kubevirt-bot kubevirt-bot merged commit 77da856 into kubevirt:main Mar 29, 2023
@akrejcir akrejcir deleted the fix-functests branch March 29, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@codingben codingben Awaiting requested review from codingben

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrejcir @kubevirt-bot @0xFelix