Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update controller-runtime to v0.15.0 #604

Closed
wants to merge 3 commits into from
Closed

chore: Update controller-runtime to v0.15.0 #604

wants to merge 3 commits into from

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 28, 2023 •
edited
Loading

What this PR does / why we need it:

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 28, 2023
@kubevirt-bot kubevirt-bot requested review from 0xFelix and akrejcir June 28, 2023 12:10
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lyarwood. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
lyarwood added 3 commits August 9, 2023 19:23
@lyarwood
chore: Bump k8s.io dependencies to v0.27.3
e12fb7b 
This includes k8s.io/go-client that was stuck on v14.0.0 and attempting
to pull in now removed v1alpha1 code from k8s.io/api

Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood
chore: Update controller-runtime to v0.15.0
9f608f7 
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0

* Make `*http.Client` configurable and use/share the same client by
  default kubernetes-sigs/controller-runtime#2122

* Remove dependency injection functions
  kubernetes-sigs/controller-runtime#2134,
  kubernetes-sigs/controller-runtime#2120

* Add context to EventHandler(s)
  kubernetes-sigs/controller-runtime#2139

* `Validator` and `CustomValidator` interfaces have been modified to
  allow returning warnings
  kubernetes-sigs/controller-runtime#2014

* operator-framework is also pinned to ecb9be48837 until a new release
  is cut supporting controller-runtime v0.15.0

Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood
chore: Fix github.com/openshift/api branch comment in go.mod
ecabbe9 
Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood lyarwood force-pushed the controller-runtime-v0.15.0 branch from ea52900 to ecabbe9 Compare August 9, 2023 18:26
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lyarwood lyarwood marked this pull request as ready for review August 9, 2023 18:26
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@kubevirt-bot kubevirt-bot requested a review from opokornyy August 9, 2023 18:26
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/win11-pipeline-example-test ea52900 link true /test win11-pipeline-example-test
ci/prow/win2k22-pipeline-example-test ea52900 link true /test win2k22-pipeline-example-test
ci/prow/win10-pipeline-example-test ea52900 link true /test win10-pipeline-example-test
ci/prow/e2e-single-node-functests ecabbe9 link true /test e2e-single-node-functests
ci/prow/e2e-upgrade-functests ecabbe9 link true /test e2e-upgrade-functests
ci/prow/e2e-functests ecabbe9 link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

0xFelix
0xFelix reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! But there are still some failing tests.

@lyarwood
Copy link
Member Author

Nice work! But there are still some failing tests.

Yeah I didn't run func tests locally, I'll clean it up now.

@lyarwood lyarwood mentioned this pull request Aug 11, 2023
Closed
@akrejcir akrejcir added this to the v0.19.0 milestone Aug 16, 2023
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2023
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akalenyu
Copy link
Contributor

Note that IsNoMatch breaks with 0.15 (among other things)
https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2333/files#r1200311040

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2023
@akrejcir
Copy link
Collaborator

akrejcir commented Dec 1, 2023

I've opened a new PR to update controller-runtime: #745

/close

@kubevirt-bot
Copy link
Contributor

@akrejcir: Closed this PR.

In response to this:

I've opened a new PR to update controller-runtime: #745

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@akrejcir akrejcir Awaiting requested review from akrejcir

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lyarwood @kubevirt-bot @akalenyu @akrejcir @0xFelix