Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add validation for vm-console-proxy annotations to webhook #510

Closed
wants to merge 1 commit into from

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Mar 1, 2023

What this PR does / why we need it:
Webhook needs to validate the annotations:

  • ssp.kubevirt.io/vm-console-proxy-enabled
  • ssp.kubevirt.io/vm-console-proxy-namespace

Release note:

None

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 1, 2023
@kubevirt-bot kubevirt-bot requested review from ksimon1 and lyarwood March 1, 2023 12:50
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir by writing /assign @akrejcir in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codingben codingben mentioned this pull request Mar 1, 2023
@akrejcir akrejcir added this to the v0.18.0 milestone May 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2023

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/win10-pipeline-example-test b497501 link true /test win10-pipeline-example-test
ci/prow/win11-pipeline-example-test b497501 link true /test win11-pipeline-example-test
ci/prow/win2k22-pipeline-example-test b497501 link true /test win2k22-pipeline-example-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2023
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir akrejcir removed this from the v0.18.0 milestone Jun 19, 2023
@akrejcir
Copy link
Collaborator Author

Is not needed anymore, because the validation webhook will be part or API change.

/close

@kubevirt-bot
Copy link
Contributor

@akrejcir: Closed this PR.

In response to this:

Is not needed anymore, because the validation webhook will be part or API change.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir akrejcir deleted the webhook-for-proxy branch April 30, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants