-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore,prow: update prow and test-infra dependencies #3888
Conversation
Signed-off-by: Daniel Hiller <[email protected]>
Updated sigs.k8s.io/prow to v0.0.0-20241224162210-8e8a5cfe7516 Signed-off-by: Daniel Hiller <[email protected]>
* update go.mod * phased plugin * testutils * referee * botreview * release blocker * push flakefinder results * external-plugin tests * deactivate kubevirt copy jobs test for job_states_to_report Signed-off-by: Daniel Hiller <[email protected]>
Signed-off-by: Daniel Hiller <[email protected]>
Signed-off-by: Daniel Hiller <[email protected]>
/rehearse pull-project-infra-job-config-validator |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
/override pull-project-infra-job-config-validator See rehearsal here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/rehearsal-pull-project-infra-job-config-validator/1879587535680704512 Also reran prow-deploy here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/pull-project-infra-prow-deploy-test/1879846078279323648 |
@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-job-config-validator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Daniel - just a couple of questions inline.
@@ -143,6 +143,21 @@ func (foc *FakeOwnersClient) ParseFullConfig(path string) (repoowners.FullConfig | |||
return *full, err | |||
} | |||
|
|||
func (foc *FakeOwnersClient) AllOwners() sets.Set[string] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface has been updated, therefore I needed to implement some more funcs.
}, | ||
wantJobStatesToReportInSerialization: true, | ||
}, | ||
// TODO it seems that job_states_to_report has gotten an omitempty which effectively removes it when serializing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we open an issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: #3901
@brianmcarey thank you for the review, PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
This is great to get the prow dependencies finally updated 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-project-infra-job-config-validator |
@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-job-config-validator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-project-infra-coverage not relevant here |
@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-coverage In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dhiller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Update prow and test-infra dependencies to latest versions. Fix compile errors and deactivate one test that is low prio.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @brianmcarey