Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore,prow: update prow and test-infra dependencies #3888

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jan 15, 2025

What this PR does / why we need it:

Update prow and test-infra dependencies to latest versions. Fix compile errors and deactivate one test that is low prio.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey

Updated sigs.k8s.io/prow to v0.0.0-20241224162210-8e8a5cfe7516

Signed-off-by: Daniel Hiller <[email protected]>
* update go.mod
* phased plugin
* testutils
* referee
* botreview
* release blocker
* push flakefinder results
* external-plugin tests
* deactivate kubevirt copy jobs test for job_states_to_report

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jan 15, 2025
@dhiller
Copy link
Contributor Author

dhiller commented Jan 15, 2025

/rehearse pull-project-infra-job-config-validator

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-job-config-validator

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-job-config-validator

In response to this:

/override pull-project-infra-job-config-validator

See rehearsal here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/rehearsal-pull-project-infra-job-config-validator/1879587535680704512

Also reran prow-deploy here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/pull-project-infra-prow-deploy-test/1879846078279323648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Daniel - just a couple of questions inline.

@@ -143,6 +143,21 @@ func (foc *FakeOwnersClient) ParseFullConfig(path string) (repoowners.FullConfig
return *full, err
}

func (foc *FakeOwnersClient) AllOwners() sets.Set[string] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface has been updated, therefore I needed to implement some more funcs.

},
wantJobStatesToReportInSerialization: true,
},
// TODO it seems that job_states_to_report has gotten an omitempty which effectively removes it when serializing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: #3901

@dhiller
Copy link
Contributor Author

dhiller commented Jan 20, 2025

@brianmcarey thank you for the review, PTAL, thanks!

@dhiller dhiller requested a review from brianmcarey January 20, 2025 08:39
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This is great to get the prow dependencies finally updated 🎉

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@dhiller
Copy link
Contributor Author

dhiller commented Jan 21, 2025

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-job-config-validator

In response to this:

/override pull-project-infra-job-config-validator

See rehearsal here: prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/rehearsal-pull-project-infra-job-config-validator/1879587535680704512

Also reran prow-deploy here: prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3888/pull-project-infra-prow-deploy-test/1879846078279323648

/override pull-project-infra-job-config-validator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Jan 21, 2025

/override pull-project-infra-coverage

not relevant here

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-coverage

In response to this:

/override pull-project-infra-coverage

not relevant here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 1e74906 into kubevirt:main Jan 21, 2025
13 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

In response to this:

What this PR does / why we need it:

Update prow and test-infra dependencies to latest versions. Fix compile errors and deactivate one test that is low prio.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants