Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export PLATFORMS=all to post-submit jobs for bridge-marker #3819

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ashokpariya0
Copy link
Contributor

This update ensures that the PLATFORMS environment variable is set to "all" before executing the make docker-build docker-push command in both main-bridge-marker and release-bridge-marker jobs. This change enables building multi-platform supported bridge marker image.

What this PR does / why we need it:
This commit (892ccdd) enables multi-platform support. By default, the image is built based on the host architecture. To build a multi-platform image that supports amd64, arm64, and s390x, the PLATFORMS=all environment variable needs to be exported before running the make docker-build command.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 11, 2024
@kubevirt-bot
Copy link
Contributor

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This update ensures that the PLATFORMS environment variable is set to "all"
before executing the `make docker-build docker-push` command in both
`main-bridge-marker` and `release-bridge-marker` jobs. This change enables
building multi-platform images

Signed-off-by: Ashok Pariya <[email protected]>
@oshoval
Copy link
Contributor

oshoval commented Dec 12, 2024

Thanks
/lgtm

@brianmcarey can you please take a look ?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks @ashokpariya0 !

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@kubevirt-bot kubevirt-bot merged commit 77c54ee into kubevirt:main Dec 12, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@ashokpariya0: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key bridge-marker-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/bridge-marker/bridge-marker-postsubmits.yaml

In response to this:

This update ensures that the PLATFORMS environment variable is set to "all" before executing the make docker-build docker-push command in both main-bridge-marker and release-bridge-marker jobs. This change enables building multi-platform supported bridge marker image.

What this PR does / why we need it:
This commit (892ccdd) enables multi-platform support. By default, the image is built based on the host architecture. To build a multi-platform image that supports amd64, arm64, and s390x, the PLATFORMS=all environment variable needs to be exported before running the make docker-build command.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants