-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export PLATFORMS=all to post-submit jobs for bridge-marker #3819
Conversation
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This update ensures that the PLATFORMS environment variable is set to "all" before executing the `make docker-build docker-push` command in both `main-bridge-marker` and `release-bridge-marker` jobs. This change enables building multi-platform images Signed-off-by: Ashok Pariya <[email protected]>
1684711
to
5337338
Compare
Thanks @brianmcarey can you please take a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks @ashokpariya0 !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ashokpariya0: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This update ensures that the PLATFORMS environment variable is set to "all" before executing the
make docker-build docker-push
command in bothmain-bridge-marker
andrelease-bridge-marker
jobs. This change enables building multi-platform supported bridge marker image.What this PR does / why we need it:
This commit (892ccdd) enables multi-platform support. By default, the image is built based on the host architecture. To build a multi-platform image that supports amd64, arm64, and s390x, the PLATFORMS=all environment variable needs to be exported before running the make docker-build command.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: