Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3d-sriov: Replace kind with k3d for SR-IOV jobs #2634

Merged
merged 5 commits into from
Mar 21, 2023
Merged

k3d-sriov: Replace kind with k3d for SR-IOV jobs #2634

merged 5 commits into from
Mar 21, 2023

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Feb 27, 2023 •
edited
Loading

Add k3d-sriov presubmit and periodic jobs.
Switch kubevirt presubmit kind with k3d as the gating job.
Disable gating of kubevirtci kind-1.23-sriov presubmit (k3d-sriov is gating already).
Fix name typo of kubevirt kind periodic

Kept the kind-1.23-sriov kubevirt periodic for now.

Depends on
kubevirt/kubevirtci#972 (need to be bumped as well)
kubevirt/kubevirt#9326

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 27, 2023
@oshoval oshoval changed the title K3dkk WIP: k3d sriov on kubevirt Feb 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023

/rehearse

1 similar comment
@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023

/rehearse

@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023 •
edited
Loading

known failures, cpu management (will fix soon)
beside that the 11/13 passed

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2634/rehearsal-pull-kubevirt-e2e-k3d-1.25-sriov/1630165686674264064

@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023

/rehearse

@oshoval oshoval changed the title WIP: k3d sriov on kubevirt WIP: k3d sriov on kubevirt, docker Feb 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Feb 28, 2023

/rehearse

1 similar comment
@oshoval
Copy link
Contributor Author

oshoval commented Feb 28, 2023

/rehearse

@oshoval oshoval mentioned this pull request Mar 1, 2023
Merged
8 tasks
@oshoval
Copy link
Contributor Author

oshoval commented Mar 1, 2023

/rehearse

1 similar comment
@oshoval
Copy link
Contributor Author

oshoval commented Mar 1, 2023

/rehearse

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@kubevirt-bot kubevirt-bot added size/L and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M labels Mar 5, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 5, 2023

/rehearse

4 similar comments
@oshoval
Copy link
Contributor Author

oshoval commented Mar 5, 2023

/rehearse

@oshoval
Copy link
Contributor Author

oshoval commented Mar 5, 2023

/rehearse

@oshoval
Copy link
Contributor Author

oshoval commented Mar 6, 2023

/rehearse

@oshoval
Copy link
Contributor Author

oshoval commented Mar 6, 2023

/rehearse

oshoval added 3 commits March 9, 2023 11:01
@oshoval
kubevirt, presubmit: Add k3d-1.25-sriov job
8e0e742 
Signed-off-by: Or Shoval <[email protected]>
@oshoval
kubevirt, presubmit: Switch kind with k3d as the always_run job
145567a 
Signed-off-by: Or Shoval <[email protected]>
@oshoval
kubevirtci, presubmit: Disable always_run of kubevirtci kind-1.23-sri…
057692d 
…ov presubmit

The k3d is already always_run for kubevirtci presubmit.

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval changed the title WIP: k3d sriov on kubevirt, docker k3d-sriov: Replace kind with k3d for SR-IOV jobs Mar 9, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 9, 2023

/cc @EdDev @brianmcarey

EdDev
EdDev reviewed Mar 12, 2023
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

I think we need an intermediate period on which this jobs runs periodically and without voting from the PR/s, to assure stability.
Maybe a periodic is enough.

After a week or so, we can do the final switch.

@oshoval
Copy link
Contributor Author

oshoval commented Mar 12, 2023 •
edited
Loading

Thank you for this!

I think we need an intermediate period on which this jobs runs periodically and without voting from the PR/s, to assure stability. Maybe a periodic is enough.

After a week or so, we can do the final switch.

Periodic will run just a few times, unless we do it more frequent as periodic
otherwise a week with just 1 per day, isn't much, wdyt?

Another option is to run it manually X times, 20 is fine ? more ?
(note that it will be a burst instead of sporadic so it is less natural than periodic)
Already run it around 10 times considering the kubevirtci runs (see below).

Thought about just switching, and if needed we can switch back,
this way we will test it on every PR, the best testing of it.
(note that it is because it was already tested at least 10 times or so)

For reverting kubevirt we can just revert this commit 145567a
not the whole PR.

Note that it is already voting as part of kubevirtci, which runs all the tests beside the 2 cpu manager ones (for some reason, was the same on kind) https://prow.ci.kubevirt.io/?job=check-up-k3d-1.25-sriov
We run both kind and k3d on kubevirtci which is redundant, this PR fix it as well.

@oshoval oshoval requested review from EdDev and removed request for rmohr, mhenriks and brianmcarey March 13, 2023 11:32
@oshoval
Copy link
Contributor Author

oshoval commented Mar 13, 2023

@EdDev
you can see here that since we speaked yesterday it ran the lane 3 times as part of
https://prow.ci.kubevirt.io/?job=check-up-k3d-1.25-sriov
which is gating already on kubevirtci

brianmcarey
brianmcarey reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@oshoval oshoval mentioned this pull request Mar 15, 2023
Merged
@oshoval
Copy link
Contributor Author

oshoval commented Mar 15, 2023 •
edited
Loading

Thanks

Edy wdyt?

It runs at least twice per day because the presubmit on kubevirtci

@oshoval oshoval marked this pull request as ready for review March 21, 2023 06:59
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 21, 2023

kubevirt/kubevirt#9326 was merged

@brianmcarey
Can you please approve as well ?

Thanks

brianmcarey
brianmcarey approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@kubevirt-bot kubevirt-bot merged commit d51c4ca into kubevirt:main Mar 21, 2023
@kubevirt-bot
Copy link
Contributor

@oshoval: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml
  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml

In response to this:

Add k3d-sriov presubmit and periodic jobs.
Switch kubevirt presubmit kind with k3d as the gating job.
Disable gating of kubevirtci kind-1.23-sriov presubmit (k3d-sriov is gating already).
Fix name typo of kubevirt kind periodic

Kept the kind-1.23-sriov kubevirt periodic for now.

Depends on
kubevirt/kubevirtci#972 (need to be bumped as well)
kubevirt/kubevirt#9326

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@EdDev EdDev Awaiting requested review from EdDev

@maiqueb maiqueb Awaiting requested review from maiqueb

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshoval @kubevirt-bot @EdDev @brianmcarey