Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirtci, k3d-sriov: Add presubmit job #2633

Merged
merged 1 commit into from
Mar 8, 2023
Merged

kubevirtci, k3d-sriov: Add presubmit job #2633

merged 1 commit into from
Mar 8, 2023

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Feb 27, 2023 •
edited
Loading

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Feb 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023

/rehearse

@oshoval oshoval changed the title WIP: k3d sriov WIP: k3d sriov kubevirtci Feb 27, 2023
@oshoval oshoval changed the title WIP: k3d sriov kubevirtci WIP: k3d sriov kubevirtci, docker Feb 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Feb 27, 2023 •
edited
Loading

/rehearse

passed
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2633/rehearsal-check-up-k3d-1.25-sriov/1630200792709337088

@oshoval oshoval mentioned this pull request Mar 1, 2023
Merged
8 tasks
@oshoval oshoval changed the title WIP: k3d sriov kubevirtci, docker kubevirtci. k3d sriov: Add presubmit job (docker) Mar 8, 2023
@oshoval oshoval changed the title kubevirtci. k3d sriov: Add presubmit job (docker) kubevirtci, k3d-sriov: Add presubmit job Mar 8, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 8, 2023

/hold

Depends on kubevirt/kubevirtci#972

@oshoval oshoval marked this pull request as ready for review March 8, 2023 11:00
@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 8, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 8, 2023

/cc @brianmcarey

@kubevirt-bot kubevirt-bot requested a review from brianmcarey March 8, 2023 11:01
brianmcarey
brianmcarey approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Mar 8, 2023

/hold cancel

972 was merged

Thanks

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2023
@kubevirt-bot kubevirt-bot merged commit d5fb318 into kubevirt:main Mar 8, 2023
@kubevirt-bot
Copy link
Contributor

@oshoval: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml

In response to this:

Depends on kubevirt/kubevirtci#972

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@awels awels Awaiting requested review from awels

@vladikr vladikr Awaiting requested review from vladikr

@phoracek phoracek Awaiting requested review from phoracek

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @brianmcarey