Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8s-1.23 SR-IOV lane jobs #2477

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Nov 22, 2022

This PR adds new periodic and presubmit jobs for testing Kubevirt SR-IOV tests on k8s-1.23 cluster (using the new SR-IOV kubecirtci provider kubevirt/kubevirtci#897).
And use the new jobs instead of the old ones (i.e: use pull-kubevirt-e2e-kind-1.23-sriov instead of pull-kubevirt-e2e-kind-1.22-sriov).

Note to reviewer:

  • Since only two SR-IOV jobs can runs simontanuasly its necessary to pick only SR-IOV lane (e.g: pull-kubevirt-e2e-kind-1.23-sriov).
  • The new kind-1.23-sriov periodic job will start after kind-1.22-sriov perodic job.
    We can remove it as soon as we see that the new periodic job is stable.

The new job should run right after 1.22 SR-IOV lane
periodic job.

Signed-off-by: Or Mergi <[email protected]>
Disable kind-1.22-sriov lane and run the new kind-1.23-sriov
lane instead.

Signed-off-by: Or Mergi <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 22, 2022
@ormergi
Copy link
Contributor Author

ormergi commented Nov 22, 2022

@ormergi
Copy link
Contributor Author

ormergi commented Nov 22, 2022

/rehearse pull-kubevirt-e2e-kind-1.23-sriov

@brianmcarey
Copy link
Member

/rehearse

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@brianmcarey
Copy link
Member

/rehearse

@oshoval
Copy link
Contributor

oshoval commented Nov 22, 2022

If possible please, next time
first create a commit that clone the existing job, and another one that changes only what is needed
easier to review and not miss anything

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@brianmcarey
Copy link
Member

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@brianmcarey
Copy link
Member

/unhold

I had a question on the 1.22 sriov periodic but answered in the PR notes.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@kubevirt-bot kubevirt-bot merged commit 2507b87 into kubevirt:main Nov 22, 2022
@kubevirt-bot
Copy link
Contributor

@ormergi: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

This PR adds new periodic and presubmit jobs for testing Kubevirt SR-IOV tests on k8s-1.23 cluster (using the new SR-IOV kubecirtci provider kubevirt/kubevirtci#897).
And use the new jobs instead of the old ones (i.e: use pull-kubevirt-e2e-kind-1.23-sriov instead of pull-kubevirt-e2e-kind-1.22-sriov).

Note to reviewer:

  • Since only two SR-IOV jobs can runs simontanuasly its necessary to pick only SR-IOV lane (e.g: pull-kubevirt-e2e-kind-1.23-sriov).
  • The new kind-1.23-sriov periodic job will start after kind-1.22-sriov perodic job.
    We can remove it as soon as we see that the new periodic job is stable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 22, 2022

If possible please, next time first create a commit that clone the existing job, and another one that changes only what is needed easier to review and not miss anything

Noted

@dhiller
Copy link
Contributor

dhiller commented Nov 22, 2022

@ormergi one note: if you want to get an overview of when the several periodics are running, there's this one available:

❯ go run ./robots/cmd/kubevirtperiodics/... --job-config-path-kubevirt-periodics /home/dhiller/Projects/github.com/kubevirt.io/project-infra/github/ci/prow-deploy/files/jobs
+------------------------------------------------------------+-------------------------------------------------+
| job_name                                                   | runs                                            |
+============================================================+=================================================+
| periodic-kubevirt-e2e-k8s-1.22-operator                    | At 12:20 AM, 08:20 AM and 04:20 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sig-compute                 | At 07:10 AM, 03:10 PM and 11:10 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sig-network                 | At 05:50 AM, 01:50 PM and 09:50 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sig-performance             | At 07:40 AM, 03:40 PM and 11:40 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sig-performance-realtime    | At 06:00 AM                                     |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sig-storage                 | At 06:00 AM, 02:00 PM and 10:00 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sriov                       | At 22 and minutes past the hour, at 10:00 AM    |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.22-sysprep                     | At 12:00 AM                                     |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-operator                    | At 01:30 AM, 09:30 AM and 05:30 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sig-compute                 | At 12:20 AM, 08:20 AM and 04:20 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sig-compute-cgroupsv2       | At 09:30 PM                                     |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sig-network                 | At 06:00 AM, 02:00 PM and 10:00 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sig-storage                 | At 07:10 AM, 03:10 PM and 11:10 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sig-storage-cgroupsv2       | At 11:30 PM                                     |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.23-sriov                       | At 22 and minutes past the hour, at 11:00 AM    |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.24-operator                    | At 02:40 AM, 10:40 AM and 06:40 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.24-sig-compute                 | At 01:30 AM, 09:30 AM and 05:30 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.24-sig-compute-migrations      | At 07:10 AM, 03:10 PM and 11:10 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.24-sig-network                 | At 07:10 AM, 03:10 PM and 11:10 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.24-sig-storage                 | At 12:20 AM, 08:20 AM and 04:20 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.25-sig-compute                 | At 02:40 AM, 10:40 AM and 06:40 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.25-sig-network                 | At 12:20 AM, 08:20 AM and 04:20 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.25-sig-operator                | At 03:50 AM, 11:50 AM and 07:50 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-k8s-1.25-sig-storage                 | At 01:30 AM, 09:30 AM and 05:30 PM              |
+------------------------------------------------------------+-------------------------------------------------+
| periodic-kubevirt-e2e-kind-1.23-vgpu                       | At 22 and minutes past the hour, at 10:00 AM    |
+------------------------------------------------------------+-------------------------------------------------+

@ormergi
Copy link
Contributor Author

ormergi commented Nov 23, 2022

Very nice, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants