Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirtci, presubmit: Add optional job to check kind-1.23-sriov #2447

Merged
merged 2 commits into from
Nov 10, 2022
Merged

kubevirtci, presubmit: Add optional job to check kind-1.23-sriov #2447

merged 2 commits into from
Nov 10, 2022

Conversation

orelmisan
Copy link
Member

kubevirt/kubevirtci#897 adds a kind-1.23-sriov provider.

Add an optional pre-submit job, in order to check kind-1.23-sriov.

@orelmisan
kubevirtci, pre-submit: Clone kind-1.22-sriov job
05a7663 
PR kubevirt/kubevirtci#897 adds a `kind-1.23-sriov` provider.

In order to test it, add an optional pre-submit job.

Clone the `kind-1.22-sriov` pre-submit job, in order to serve as
a base for `kind-1.23-sriov` pre-submit job.

Signed-off-by: Orel Misan <[email protected]>
@orelmisan
kubevirtci, pre-submit: Add optional job to check kind-1.23-sriov
72571fc 
Make the kind-1.23-sriov pre-submit job optional.

Signed-off-by: Orel Misan <[email protected]>
@orelmisan
Copy link
Member Author

/cc @brianmcarey @dhiller

dhiller
dhiller approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@brianmcarey
Copy link
Member

/check-dco

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 10, 2022
@brianmcarey
Copy link
Member

/retest-required

brianmcarey
brianmcarey reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot merged commit 032dcc6 into kubevirt:main Nov 10, 2022
@kubevirt-bot
Copy link
Contributor

@orelmisan: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml

In response to this:

kubevirt/kubevirtci#897 adds a kind-1.23-sriov provider.

Add an optional pre-submit job, in order to check kind-1.23-sriov.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orelmisan orelmisan deleted the optional_kind-1.23-sriov_job branch November 10, 2022 14:15
@orelmisan orelmisan mentioned this pull request Nov 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey left review comments

@dhiller dhiller dhiller approved these changes

Assignees

@dhiller dhiller

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orelmisan @kubevirt-bot @brianmcarey @dhiller