Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OperatorConditionsUnhealth alert name #277

Merged

Conversation

sradco
Copy link
Collaborator

@sradco sradco commented Dec 25, 2024

This change is part of kubevirt/hyperconverged-cluster-operator#3242.

Update OperatorConditionsUnhealth alert name
to HCOOperatorConditionsUnhealth.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #jira-ticket: https://issues.redhat.com/browse/CNV-52735

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@sradco sradco requested review from nunnatsa and avlitman December 25, 2024 09:36
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 25, 2024
@kubevirt-bot kubevirt-bot requested a review from ousleyp December 25, 2024 09:36
@sradco
Copy link
Collaborator Author

sradco commented Dec 25, 2024

@avlitman @nunnatsa please review this PR

@nunnatsa
Copy link
Collaborator

@sradco please fix the linter warnings before I could approve thr pr

@avlitman
Copy link
Collaborator

/lgtm

just rebase and fix sanity

@sradco sradco force-pushed the update_OperatorConditionsUnhealthy_alert_name branch from 486b85e to 4ce2462 Compare December 26, 2024 12:52
Update OperatorConditionsUnhealth alert name
to HCOOperatorConditionsUnhealth.

Signed-off-by: Shirly Radco <[email protected]>
@sradco sradco force-pushed the update_OperatorConditionsUnhealthy_alert_name branch from 4ce2462 to 1a38f89 Compare December 26, 2024 12:54
@nunnatsa nunnatsa merged commit d534621 into kubevirt:main Dec 26, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
…onditionsUnhealthy_alert_name

Update OperatorConditionsUnhealth alert name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants