Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #971

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix some typos #971

merged 1 commit into from
Mar 8, 2023

Conversation

zhouhao3
Copy link
Contributor

No description provided.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 27, 2023
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2023
@kubevirt-bot
Copy link
Contributor

Hi @zhouhao3. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brianmcarey
Copy link
Member

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2023
@brianmcarey
Copy link
Member

/cc @brianmcarey

@kubevirt-bot kubevirt-bot requested a review from brianmcarey March 2, 2023 07:58
brianmcarey
brianmcarey reviewed Mar 7, 2023
View reviewed changes
cluster-up/README.md Outdated Show resolved Hide resolved
@zhouhao3
Fix some typos
ea4a039 
Signed-off-by: Zhou Hao <[email protected]>
brianmcarey
brianmcarey approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@kubevirt-bot kubevirt-bot merged commit 42c3f70 into kubevirt:main Mar 8, 2023
@zhouhao3 zhouhao3 deleted the fix-typo branch March 8, 2023 08:59
@oshoval
Copy link
Contributor

oshoval commented Mar 8, 2023

Thanks for the PR

@dhiller @brianmcarey
Note please that with provision manager we won't rebuild provider when md files are changed
moreover since less providers would be built, less jobs are prone to fail as they now fail and the whole 3h might have to be redone

@kubevirt-bot kubevirt-bot mentioned this pull request Mar 9, 2023
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Mar 9, 2023
@kubevirt-bot
Bump kubevirtci
4b40450 
[7e486e5 k3d: Introduce k3d SR-IOV provider](kubevirt/kubevirtci#972)
[42c3f70 Fix some typos](kubevirt/kubevirtci#971)
[e37ca14 Remove the centos8 based k8s-1.26 provider](kubevirt/kubevirtci#969)
[46a9824 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#974)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Mar 9, 2023
@kubevirt-bot
Bump kubevirtci
be36db4 
[3e52bb0 kind, vgpu: Bump vgpu kind to k8s-1.25](kubevirt/kubevirtci#979)
[7e486e5 k3d: Introduce k3d SR-IOV provider](kubevirt/kubevirtci#972)
[42c3f70 Fix some typos](kubevirt/kubevirtci#971)
[e37ca14 Remove the centos8 based k8s-1.26 provider](kubevirt/kubevirtci#969)
[46a9824 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#974)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
germag pushed a commit to germag/kubevirt that referenced this pull request Mar 13, 2023
@kubevirt-bot @germag
Bump kubevirtci
41d527f 
[3e52bb0 kind, vgpu: Bump vgpu kind to k8s-1.25](kubevirt/kubevirtci#979)
[7e486e5 k3d: Introduce k3d SR-IOV provider](kubevirt/kubevirtci#972)
[42c3f70 Fix some typos](kubevirt/kubevirtci#971)
[e37ca14 Remove the centos8 based k8s-1.26 provider](kubevirt/kubevirtci#969)
[46a9824 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#974)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhouhao3 @kubevirt-bot @brianmcarey @oshoval