Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Seccomp configuration #960

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Enable Seccomp configuration #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cluster-provision/k8s/check-cluster-up.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ export KUBEVIRTCI_GOCLI_CONTAINER=quay.io/kubevirtci/gocli:latest

${ksh} wait -n kubevirt kv kubevirt --for condition=Available --timeout 15m

if [ "${KUBEVIRT_PSA:-"false"}" == "true" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need the default value please because we have it here already

kubevirtci/cluster-up/hack/common.sh

Line 25 in 31e5860

KUBEVIRT_PSA=${KUBEVIRT_PSA:-false}

Easier to read without it imo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./check-cluster-up.sh: line 97: KUBEVIRT_PSA: unbound variable

Not sure what you are suggesting...

Copy link
Contributor

@oshoval oshoval Feb 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok it doesnt import this file, as it is check-up

so it is better please to set KUBEVIRT_PSA to either false or true in the section of check-cluster-up where we set all the rest, but not in the condition itself imo

# Enable Kubevirt profile
${ksh} patch -n kubevirt kv kubevirt --type='merge' --patch '{"spec": {"configuration": {"developerConfiguration": {"featureGates": ["KubevirtSeccompProfile"]} } }}'
${ksh} patch -n kubevirt kv kubevirt --type='merge' --patch '{"spec": {"configuration": {"seccompConfiguration": {"virtualMachineInstanceProfile": {"customProfile": {"localhostProfile" : "kubevirt/kubevirt.json"} } } } } }'
fi

export SONOBUOY_EXTRA_ARGS="--plugin https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/${LATEST}/conformance.yaml"
hack/conformance.sh $conformance_config
fi
Expand Down