Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default provider version #894

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Bump default provider version #894

merged 1 commit into from
Nov 8, 2022

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Nov 8, 2022

No description provided.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 8, 2022
brianmcarey
brianmcarey reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to bump it in the documentation too -

kubevirtci/KUBEVIRTCI_LOCAL_TESTING.md

Line 38 in 8cca8c0

export KUBEVIRT_PROVIDER=k8s-1.22

kubevirtci/KUBEVIRTCI_LOCAL_TESTING.md

Line 19 in 8cca8c0

(cd cluster-provision/k8s/1.22; ../provision.sh)

kubevirtci/K8S.md

Line 11 in 8cca8c0

export KUBEVIRT_PROVIDER=k8s-1.22 KUBEVIRT_NUM_NODES=2 KUBEVIRT_NUM_SECONDARY_NICS=1

@xpivarc xpivarc force-pushed the bump-default-provider branch from adef9ac to 9ece7dc Compare November 8, 2022 09:12
dhiller
dhiller approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@dhiller
Copy link
Contributor

dhiller commented Nov 8, 2022

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@xpivarc
Copy link
Member Author

xpivarc commented Nov 8, 2022

@dhiller @brianmcarey Maybe we can also remove the 1.22 check?

@dhiller
Copy link
Contributor

dhiller commented Nov 8, 2022

@dhiller @brianmcarey Maybe we can also remove the 1.22 check?

While the provider is still there we might just make it optional?

@brianmcarey
Copy link
Member

It could be good to bump it in the documentation too -

kubevirtci/KUBEVIRTCI_LOCAL_TESTING.md

Line 38 in 8cca8c0

export KUBEVIRT_PROVIDER=k8s-1.22

kubevirtci/KUBEVIRTCI_LOCAL_TESTING.md

Line 19 in 8cca8c0

(cd cluster-provision/k8s/1.22; ../provision.sh)

kubevirtci/K8S.md

Line 11 in 8cca8c0

export KUBEVIRT_PROVIDER=k8s-1.22 KUBEVIRT_NUM_NODES=2 KUBEVIRT_NUM_SECONDARY_NICS=1

Thanks for addressing these @xpivarc

/unhold

/lgtm

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@kubevirt-bot kubevirt-bot merged commit fa031f8 into kubevirt:main Nov 8, 2022
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 10, 2022
@kubevirt-bot
Bump kubevirtci
3e594f1 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 10, 2022
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 10, 2022
@kubevirt-bot
Bump kubevirtci
4c6676b 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 11, 2022
@kubevirt-bot
Bump kubevirtci
24ea4f2 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 11, 2022
@kubevirt-bot
Bump kubevirtci
c474741 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 11, 2022
@kubevirt-bot
Bump kubevirtci
8933bc8 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 11, 2022
@kubevirt-bot
Bump kubevirtci
08d682e 
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 11, 2022
@kubevirt-bot
Bump kubevirtci
f727c62 
[dd31ea6 bump: k8s-1.2[4,5] to cnao v0.81.0](kubevirt/kubevirtci#895)
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 22, 2022
@kubevirt-bot
Bump kubevirtci
63350d0 
[021efaa Revert "bump: k8s-1.2[4,5] to cnao v0.81.0](https://github.com/kubevirt/kubevirtci/pull/895)"](https://github.com/kubevirt/kubevirtci/pull/904)
[75a155b vm based providers: Change default dns host port](kubevirt/kubevirtci#903)
[71777d3 Support centos9 provisioner ](kubevirt/kubevirtci#896)
[3ddc5b7 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#898)
[765bf0b kind-1.23-sriov: Remove SR-IOV operator leftovers](kubevirt/kubevirtci#899)
[2f57cdf Create kind-1.23-sriov provider](kubevirt/kubevirtci#897)
[dd31ea6 bump: k8s-1.2[4,5] to cnao v0.81.0](kubevirt/kubevirtci#895)
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Barakmor1 pushed a commit to Barakmor1/kubevirt that referenced this pull request Nov 24, 2022
@kubevirt-bot
Bump kubevirtci
6af2e31 
[021efaa Revert "bump: k8s-1.2[4,5] to cnao v0.81.0](https://github.com/kubevirt/kubevirtci/pull/895)"](https://github.com/kubevirt/kubevirtci/pull/904)
[75a155b vm based providers: Change default dns host port](kubevirt/kubevirtci#903)
[71777d3 Support centos9 provisioner ](kubevirt/kubevirtci#896)
[3ddc5b7 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#898)
[765bf0b kind-1.23-sriov: Remove SR-IOV operator leftovers](kubevirt/kubevirtci#899)
[2f57cdf Create kind-1.23-sriov provider](kubevirt/kubevirtci#897)
[dd31ea6 bump: k8s-1.2[4,5] to cnao v0.81.0](kubevirt/kubevirtci#895)
[fa031f8 Bump default provider version](kubevirt/kubevirtci#894)
[8cca8c0 vm based providers: Expose a UDP port for DNS](kubevirt/kubevirtci#867)
[2fea446 kind-1.22-sriov, provider.sh: Remove unused SRIOV_TESTS_NS variable](kubevirt/kubevirtci#891)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey left review comments

@dhiller dhiller dhiller approved these changes

@awels awels Awaiting requested review from awels

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@dhiller dhiller

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xpivarc @kubevirt-bot @dhiller @brianmcarey