Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-up: Avoid a known comon issue when using podman #743

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Feb 1, 2022

There is currently a known conmon issue [1] when podman based containers
dump large amounts of data to stdout. gocli would previously do this
when copying the kubectl binary to the host machine.

This change replaces that with a simple volume mount workaround when
using podman until the underlying conmon issue is resolved.

[1] containers/conmon#315

Signed-off-by: Lee Yarwood [email protected]

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 1, 2022
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2022
@kubevirt-bot
Copy link
Contributor

Hi @lyarwood. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rmohr
Copy link
Member

rmohr commented Feb 3, 2022

@lyarwood nice, thanks!

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2022
@rmohr
Copy link
Member

rmohr commented Feb 3, 2022

/retest

1 similar comment
@lyarwood
Copy link
Member Author

lyarwood commented Feb 3, 2022

/retest

@qinqon
Copy link
Contributor

qinqon commented Feb 10, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@lyarwood
Copy link
Member Author

Error: initializing source docker://quay.io/kubevirt/cluster-network-addon-multus@sha256:32867c73cda4d605651b898dc85fea67d93191c47f27e1ad9e9f2b9041c518de: reading manifest sha256:32867c73cda4d605651b898dc85fea67d93191c47f27e1ad9e9f2b9041c518de in quay.io/kubevirt/cluster-network-addon-multus: manifest unknown: manifest unknown

Looks like something or someone removed that SHA?

v3.4.2 was moved to SHA256 [f7350c519d18](https://quay.io/repository/kubevirt/cluster-network-addon-multus/manifest/sha256:f7350c519d18b2f0fe3ec7acef556b7c42ccdb482ac929a13eb6e66615911da4) from SHA256 [32867c73cda4](https://quay.io/repository/kubevirt/cluster-network-addon-multus/manifest/sha256:32867c73cda4d605651b898dc85fea67d93191c47f27e1ad9e9f2b9041c518de)

I'll move the operators over to the actual version instead.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 10, 2022
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 10, 2022
@lyarwood
Copy link
Member Author

lyarwood commented Feb 10, 2022

Wonderful, c142361 has fixed cluster-provision, if anyone would like that in a separate PR please let me know as I'm still getting use to this many commits in a single Github PR thing after moving over from Gerrit.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2022
There is currently a known conmon issue [1] when podman based containers
dump large amounts of data to stdout. gocli would previously do this
when copying the kubectl binary to the host machine.

This change replaces that with a simple volume mount workaround when
using podman until the underlying conmon issue is resolved.

[1] containers/conmon#315

Signed-off-by: Lee Yarwood <[email protected]>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2022
@kubevirt-bot
Copy link
Contributor

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.20 473be5a link false /test check-provision-k8s-1.20
check-provision-k8s-1.20-cgroupsv2 473be5a link false /test check-provision-k8s-1.20-cgroupsv2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lyarwood
Copy link
Member Author

I've removed c142361 for now as db53467 that prompted the needs-rebase label appears to use an accessible SHA again.

@qinqon
Copy link
Contributor

qinqon commented Feb 15, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@kubevirt-bot kubevirt-bot merged commit e8e741d into kubevirt:main Feb 15, 2022
@lyarwood lyarwood deleted the conmon-workaround branch February 15, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants