-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-up: Avoid a known comon issue when using podman #743
Conversation
Hi @lyarwood. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lyarwood nice, thanks! /ok-to-test |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like something or someone removed that SHA?
I'll move the operators over to the actual version instead. |
ff239ae
to
ebddf44
Compare
ebddf44
to
140a460
Compare
140a460
to
52ee5e6
Compare
Wonderful, c142361 has fixed cluster-provision, if anyone would like that in a separate PR please let me know as I'm still getting use to this many commits in a single Github PR thing after moving over from Gerrit. |
There is currently a known conmon issue [1] when podman based containers dump large amounts of data to stdout. gocli would previously do this when copying the kubectl binary to the host machine. This change replaces that with a simple volume mount workaround when using podman until the underlying conmon issue is resolved. [1] containers/conmon#315 Signed-off-by: Lee Yarwood <[email protected]>
52ee5e6
to
473be5a
Compare
@lyarwood: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
There is currently a known conmon issue [1] when podman based containers
dump large amounts of data to stdout. gocli would previously do this
when copying the kubectl binary to the host machine.
This change replaces that with a simple volume mount workaround when
using podman until the underlying conmon issue is resolved.
[1] containers/conmon#315
Signed-off-by: Lee Yarwood [email protected]