Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup to emulate SCSI devices #691

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add setup to emulate SCSI devices #691

merged 1 commit into from
Oct 27, 2021

Conversation

alicefr
Copy link
Member

@alicefr alicefr commented Oct 12, 2021

Use emulated scsi devices in the provisioned nodes for development and testing.

Set the variable KUBEVIRT_PROVIDER_EXTRA_ARGS="--scsi 1G" for creating a SCSI disk during the node creation.

This PR adds a similar setup for SCSI devices like #672 for NVMe devices.
Example

$ export KUBEVIRT_PROVIDER_EXTRA_ARGS="--scsi 1G" 
$ make cluster-up
[...]
$ cluster-up/ssh.sh node01
WARNING: KUBEVIRTCI_GOCLI_CONTAINER is set and will take precedence over the also set KUBEVIRTCI_TAG
selecting docker as container runtime
2021/10/12 10:08:26 Waiting for host: 192.168.66.101:22
2021/10/12 10:08:26 Connected to tcp://192.168.66.101:22
$ lsscsi
[0:0:0:0]    disk    QEMU     QEMU HARDDISK    2.5+  /dev/sda
$ lsblk /dev/sda 
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
sda    8:0    0   1G  0 disk

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2021
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2021
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 12, 2021
@alicefr
Copy link
Member Author

alicefr commented Oct 13, 2021

/retest

@alicefr
Copy link
Member Author

alicefr commented Oct 14, 2021

/test check-provision-k8s-1.22

@alicefr
Add setup to emulate SCSI devices
a44ba0b 
Use emulated scsi devices in the provisioned nodes for development and
testing.

Set the variable KUBEVIRT_PROVIDER_EXTRA_ARGS="--scsi 1G" for creating a
SCSI disk during the node creation.

Signed-off-by: Alice Frosi <[email protected]>
@alicefr alicefr mentioned this pull request Oct 25, 2021
Merged
dhiller
dhiller approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Looks good to me from code review side.

@mhenriks @awels @maya-r do any of you or someone else from your team have time for a quick look at this?

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@awels
Copy link
Member

awels commented Oct 27, 2021

Don't quite understand what it is I am looking at, but I don't see anything wrong with it.

@alicefr
Copy link
Member Author

alicefr commented Oct 27, 2021 •
edited
Loading

@awels it is a setup to allow the creation of SCSI devices in the provisioned node. This might be useful for testing scsi functionalities. At least, I also used it for verifying the lun disks that have a bug kubevirt/kubevirt#6672

@dhiller
Copy link
Contributor

dhiller commented Oct 27, 2021

Don't quite understand what it is I am looking at, but I don't see anything wrong with it.

Sorry to bother then. I think if you were able to verify it by using it @alicefr then it should be good to go.

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@kubevirt-bot kubevirt-bot merged commit 7ca1f13 into kubevirt:main Oct 27, 2021
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 28, 2021
@kubevirt-bot
Bump kubevirtci
587281c 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Oct 28, 2021
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 28, 2021
@kubevirt-bot
Bump kubevirtci
efe8d4c 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 29, 2021
@kubevirt-bot
Bump kubevirtci
2b51a68 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 29, 2021
@kubevirt-bot
Bump kubevirtci
93d5613 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 30, 2021
@kubevirt-bot
Bump kubevirtci
f8de207 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 30, 2021
@kubevirt-bot
Bump kubevirtci
5bfb699 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 31, 2021
@kubevirt-bot
Bump kubevirtci
ddc6a2e 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 31, 2021
@kubevirt-bot
Bump kubevirtci
eea8530 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 1, 2021
@kubevirt-bot
Bump kubevirtci
1cc8608 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 1, 2021
@kubevirt-bot
Bump kubevirtci
015e171 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 2, 2021
@kubevirt-bot
Bump kubevirtci
b3d18a8 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 2, 2021
@kubevirt-bot
Bump kubevirtci
a0c050b 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 3, 2021
@kubevirt-bot
Bump kubevirtci
d4a6816 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 3, 2021
@kubevirt-bot
Bump kubevirtci
0eef865 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
iholder101 pushed a commit to iholder101/kubevirt that referenced this pull request Nov 7, 2021
@kubevirt-bot @iholder101
Bump kubevirtci
0945853 
[7ca1f13 Add setup to emulate SCSI devices](kubevirt/kubevirtci#691)

Signed-off-by: kubevirt-bot <[email protected]>
@alicefr alicefr mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller approved these changes

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@dhiller dhiller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alicefr @kubevirt-bot @awels @dhiller