Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instruction to use K8s 1.21 since 1.16 already been deprecated. #667

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Update instruction to use K8s 1.21 since 1.16 already been deprecated. #667

merged 2 commits into from
Sep 13, 2021

Conversation

cydu-cloud
Copy link
Contributor

Update instruction to use K8s 1.21 since 1.16 already been deprecated.
With more info about how to specify KUBEVIRTCI_TAG.

Signed-off-by: Chuanying Du [email protected]

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 29, 2021
@kubevirt-bot kubevirt-bot requested review from qinqon and vladikr August 29, 2021 21:09
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 29, 2021
@kubevirt-bot
Copy link
Contributor

Hi @cydu-cloud. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maya-r
Copy link
Contributor

maya-r commented Aug 30, 2021

/lgtm
/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2021
@qinqon
Copy link
Contributor

qinqon commented Sep 13, 2021

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@kubevirt-bot kubevirt-bot merged commit 1a96266 into kubevirt:main Sep 13, 2021
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 13, 2021
@kubevirt-bot
Bump kubevirtci
fe32bb6 
[1a96266 Update instruction to use K8s 1.21 since 1.16 already been deprecated.](kubevirt/kubevirtci#667)
[4e3eb21 Add setup to emulate NVMe device](kubevirt/kubevirtci#672)

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Sep 13, 2021
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 14, 2021
@kubevirt-bot
Bump kubevirtci
723a177 
[1a96266 Update instruction to use K8s 1.21 since 1.16 already been deprecated.](kubevirt/kubevirtci#667)
[4e3eb21 Add setup to emulate NVMe device](kubevirt/kubevirtci#672)

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon Awaiting requested review from qinqon

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@qinqon qinqon

@maya-r maya-r

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cydu-cloud @kubevirt-bot @maya-r @qinqon