Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtctl.sh: remove script and generate error #1369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Feb 5, 2025

What this PR does / why we need it:

As discussed in #1277 the script virtctl.sh exists only as an artifact before kubevirtci was moved to it's own repository. It has been replaced by a kubevirt/kubevirt script that does the same, which should be used further on.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1277

Special notes for your reviewer:
/cc @brianmcarey

As discussed in kubevirt#1277 the
script virtctl.sh exists only as an artifact before kubevirtci was moved
to it's own repository. It has been replaced by a kubevirt/kubevirt
script that does the same, which should be used further on.

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 5, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dosubot dosubot bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 5, 2025
@kubevirt-bot
Copy link
Contributor

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.31-s390x fa699d5 link false /test check-provision-k8s-1.31-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug, deep coupling: virtctl.sh expects virtctl binary to be present in a certain folder
2 participants