-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster kind: update kind-1.23 to kind-1.27 #1027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For adding a provider - its generally better to copy the existing provider in the first commit and then make the required updates. It can be difficult to update a provider like this as there maybe lanes in kubevirt that still rely on kind-1.23 but the update PR will fail because the provider no longer exists.
The old provider can be removed easily in a follow up PR.
Yes, you are right. Updated. |
@zhlhahaha: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Can you please remove the previous folder ? |
Yes, we will remove kind-1.23 in follow up PR. as you can see @brianmcarey 's comments #1027 (review)
I have a little concern that if we remove kind-1.23 in this PR, there would be some time gap among sync kubevirtci, kubevirt, and updating the arm64 e2e test job in project-infra. The time gap may lead to crash of e2e test on Arm64. By keeping the kind-1.23, we can make sure the migration of e2e test on Arm64 smoothly from kind-1.23 to kind-1.27. |
Signed-off-by: howard zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Weird it didn't catch the approval /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027) [865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027) [865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027) [865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027) [865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
Update to kind-1.27. I have verified that e2e test on Arm64 works well in kind-1.27 cluster.