Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster kind: update kind-1.23 to kind-1.27 #1027

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

zhlhahaha
Copy link
Contributor

@zhlhahaha zhlhahaha commented Jun 13, 2023

Update to kind-1.27. I have verified that e2e test on Arm64 works well in kind-1.27 cluster.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 13, 2023
@kubevirt-bot kubevirt-bot requested review from awels and ormergi June 13, 2023 10:03
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding a provider - its generally better to copy the existing provider in the first commit and then make the required updates. It can be difficult to update a provider like this as there maybe lanes in kubevirt that still rely on kind-1.23 but the update PR will fail because the provider no longer exists.

The old provider can be removed easily in a follow up PR.

@zhlhahaha
Copy link
Contributor Author

For adding a provider - its generally better to copy the existing provider in the first commit and then make the required updates. It can be difficult to update a provider like this as there maybe lanes in kubevirt that still rely on kind-1.23 but the update PR will fail because the provider no longer exists.

The old provider can be removed easily in a follow up PR.

Yes, you are right. Updated.

@kubevirt-bot
Copy link
Contributor

@zhlhahaha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.25-vgpu a813f5d link false /test check-up-kind-1.25-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

cluster-up/cluster/kind-1.27/provider.sh Outdated Show resolved Hide resolved
cluster-up/cluster/kind-1.27/README.md Outdated Show resolved Hide resolved
@oshoval
Copy link
Contributor

oshoval commented Jun 14, 2023

Can you please remove the previous folder ?
kind-1.23 (unless I missed that it was removed or so)
unless you want to do it on a different PR
note that we doing it on steps because we have to bump in kubevirt,
but imho if it doesn't posses risks for you you can do it in one shot

@zhlhahaha
Copy link
Contributor Author

Can you please remove the previous folder ? kind-1.23 (unless I missed that it was removed or so) unless you want to do it on a different PR note that we doing it on steps because we have to bump in kubevirt,

Yes, we will remove kind-1.23 in follow up PR. as you can see @brianmcarey 's comments #1027 (review)

but imho if it doesn't posses risks for you you can do it in one shot

I have a little concern that if we remove kind-1.23 in this PR, there would be some time gap among sync kubevirtci, kubevirt, and updating the arm64 e2e test job in project-infra. The time gap may lead to crash of e2e test on Arm64. By keeping the kind-1.23, we can make sure the migration of e2e test on Arm64 smoothly from kind-1.23 to kind-1.27.

Signed-off-by: howard zhang <[email protected]>
Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@oshoval
Copy link
Contributor

oshoval commented Jun 15, 2023

Weird it didn't catch the approval

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@kubevirt-bot kubevirt-bot merged commit 6101481 into kubevirt:main Jun 15, 2023
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 16, 2023
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027)
[865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
victortoso pushed a commit to victortoso/kubevirt that referenced this pull request Jun 22, 2023
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027)
[865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
akalenyu pushed a commit to akalenyu/kubevirt that referenced this pull request Jul 13, 2023
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027)
[865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
VirrageS pushed a commit to VirrageS/kubevirt that referenced this pull request Nov 17, 2023
[6101481 cluster kind: add kind-1.27](kubevirt/kubevirtci#1027)
[865e563 k8s-1.27: Bump CRIO](kubevirt/kubevirtci#1029)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants