Update CDI lab to match the current behavior #914
Conversation
kubevirt-bot
added
do-not-merge/work-in-progress
alromeros
changed the title
alromeros
force-pushed
the
update-cdi-lab
branch
2 times, most recently
from
873e65f to
dec1bbf
Compare
alromeros
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
| requests: | ||
| storage: 5Gi | ||
| storage: | ||
| accessModes: |
There was a problem hiding this comment.
Should we leave out the volume mode and access mode? I get that the lab is more likely to work if we choose RWO/Filesystem but is that teaching a bad behavior (since we would want RWX if possible).
There was a problem hiding this comment.
Sure I can leave them out if preferred.
alromeros
force-pushed
the
update-cdi-lab
branch
from
dec1bbf to
563ec4f
Compare
| storage: 5Gi | ||
| source: | ||
| http: | ||
| url: "https://download.fedoraproject.org/pub/fedora/linux/releases/36/Cloud/x86_64/images/Fedora-Cloud-Base-36-1.5.x86_64.raw.xz" |
There was a problem hiding this comment.
Fedora 36 is getting old, since you're refreshing the lab, could you update this to 37?
There was a problem hiding this comment.
Good point. Thanks!
labs/kubernetes/lab2.md
Outdated
| @@ -42,13 +42,13 @@ Review the "cdi" pods that were added. | |||
|
|
|||
| #### Use CDI to Import a Disk Image | |||
|
|
|||
| As an example, we will import a Fedora36 Cloud Image as a PVC and launch a Virtual Machine making use of it. | |||
| First, you need to create a DataVolume that points to the source data you want to import. In this example, we'll use a DataVolume to import a Fedora36 Cloud Image into a PVC and launch a Virtual Machine making use of it. | |||
There was a problem hiding this comment.
If you update to 37, it's mentioned again here...
The CDI lab in kubevirt.io contains out-of-date processes and information, to the point where it recommends the creation of a PVC with import annotations instead of a DataVolume. This commit updates it to match the expected usage. Signed-off-by: Alvaro Romero <[email protected]>
alromeros
force-pushed
the
update-cdi-lab
branch
from
563ec4f to
1c78e99
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cwilkers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
The CDI lab in kubevirt.io contains out-of-date processes and information, to the point where it recommends the creation of a PVC with import annotations instead of a DataVolume. The given example simply doesn't work with the latest CDI version.
Though we plan to eventually change the way CDI works with DataVolumes (check kubevirt/containerized-data-importer#2752 for more information), the lab should at least provide a working example so users can test CDI's latest versions.
With the adoption of populators this process will require an update again soon, but since users have been reporting issues with the current lab (kubevirt/containerized-data-importer#2830 or kubevirt/containerized-data-importer#2645 (comment)) at least we should fix it for the moment.