Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e, primaryUDN: Align with OVNK changes #89

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

RamLavi
Copy link
Contributor

@RamLavi RamLavi commented Jan 23, 2025

What this PR does / why we need it:

  1. Following the change on ovn-kubevernets, this PR aligns the binding name to l2bridge.
  2. Following the change on ovn-kubevernets, this PR aligns the namespace to have the primary UDN label.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Following the change on ovn-kubevernets [0], aligning the binding.

[0] ovn-kubernetes/ovn-kubernetes#4854

Signed-off-by: Ram Lavi <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jan 23, 2025
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@RamLavi RamLavi changed the title e2e, primaryUDN: Change binding name to l2bridge e2e, primaryUDN: Align with OVNK changes Jan 23, 2025
Aligning with Ovn-kubernetes change [0], now namespaces that deploy
primary-udn workloads need to be created with a specific label.

[0] ovn-kubernetes/ovn-kubernetes#4912

Signed-off-by: Ram Lavi <[email protected]>
@kubevirt-bot kubevirt-bot added size/S and removed lgtm Indicates that a PR is ready to be merged. size/XS labels Jan 23, 2025
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@kubevirt-bot kubevirt-bot merged commit 3fb79b7 into kubevirt:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants