Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies in the release notes tool #3250

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

nunnatsa
Copy link
Collaborator

What this PR does / why we need it:

The tool uses an internal package, with own go.mod file with no good reason. This PR removes this go.mod file, to simplify the release-notes dependencies.

Also, did some cosmetic fixes regarding text output, to make the code more clear.

Jira Ticket:

None

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 30, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 30, 2024

Pull Request Test Coverage Report for Build 12546613114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.846%

Totals Coverage Status
Change from base Build 12543864957: 0.04%
Covered Lines: 6140
Relevant Lines: 8546

💛 - Coveralls

@nunnatsa nunnatsa force-pushed the fix-rn-dependencies branch from b36b8aa to 6d7a1e6 Compare December 30, 2024 12:33
@avlitman
Copy link
Collaborator

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avlitman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2024
@kubevirt-bot kubevirt-bot merged commit d9809b2 into kubevirt:main Dec 31, 2024
15 checks passed
@nunnatsa nunnatsa deleted the fix-rn-dependencies branch December 31, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants