cluster-up: Fix tag updating #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
|
/cc @tiraboschi @orenc1 |
Pull Request Test Coverage Report for Build 3757146658
💛 - Coveralls |
nunnatsa
reviewed
Dec 22, 2022
|
Thanks @oshoval - good catch! Added an optional nit comment. |
In case the _kubevirtci folder exists, changing the tag won't reclone the folder. The cluster-up folder won't be updated and it can lead to bugs in case the folder is changed. Fix it by deleting the folder in case of tag mismatch. It will enforce a reclone. Signed-off-by: Or Shoval <[email protected]>
|
Thanks |
|
Kudos, SonarCloud Quality Gate passed!
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
tiraboschi
pushed a commit
to tiraboschi/hyperconverged-cluster-operator
that referenced
this pull request
Mar 14, 2023
In case the _kubevirtci folder exists, changing the tag won't reclone the folder. The cluster-up folder won't be updated and it can lead to bugs in case the folder is changed. Fix it by deleting the folder in case of tag mismatch. It will enforce a reclone. Signed-off-by: Or Shoval <[email protected]> Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* [release-1.8] Align github actions from newer branches Backport a few configuration changes in github actions. Signed-off-by: stirabos <[email protected]> * Fix bug and change cri selection procedure of cluster-sync. (#2155) The command for getting the registry port gets more than one output, which breaks following commands in the deploying scripts. The output is now parsed to pickup just the first port. Also the container runtime selection was hardcoded, now it uses the cri selection script of kubervirtci. Co-authored-by: Felix Matouschek <[email protected]> Signed-off-by: Javier Cano Cano <[email protected]> Signed-off-by: Javier Cano Cano <[email protected]> Co-authored-by: Felix Matouschek <[email protected]> * cluster-up: Fix tag updating (#2189) In case the _kubevirtci folder exists, changing the tag won't reclone the folder. The cluster-up folder won't be updated and it can lead to bugs in case the folder is changed. Fix it by deleting the folder in case of tag mismatch. It will enforce a reclone. Signed-off-by: Or Shoval <[email protected]> Signed-off-by: Or Shoval <[email protected]> * Bump the default kubevirtci provider Signed-off-by: stirabos <[email protected]> * Workaround for SELinux boolean for chardev Workaround for kubevirt/kubevirt#9434 we started setting SELinux boolean for chardev access with kubevirt/kubevirtci#968 but it got reverted with kubevirt/kubevirtci#975 altough it's still needed with Kubevirt v0.58.1 TODO: let's remove this once kubevirt/kubevirt#9434 is fixed Signed-off-by: stirabos <[email protected]> --------- Signed-off-by: stirabos <[email protected]> Signed-off-by: Javier Cano Cano <[email protected]> Signed-off-by: Or Shoval <[email protected]> Co-authored-by: Javier Cano Cano <[email protected]> Co-authored-by: Felix Matouschek <[email protected]> Co-authored-by: oscollabus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the _kubevirtci folder exists,
changing the tag won't reclone the folder.
The cluster-up folder won't be updated and it can lead to bugs in case the folder is changed.
Fix it by deleting the folder in case of tag mismatch.
It will enforce a reclone.
Reviewer Checklist
Release note: