Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make rpm-deps to udpate dependencies for all arches #3405

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

awels
Copy link
Member

@awels awels commented Aug 21, 2024

What this PR does / why we need it:
Ensure the dependencies are up to date so we can easily merge with s390x PRs in the future.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 21, 2024
@mhenriks
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@akalenyu
Copy link
Collaborator

So this is going to have issues with the latest nginx version and https imports:

$ k logs -n cdi cdi-file-host-8449b596c9-4pq6g | grep dumped
selecting docker as container runtime
Defaulted container "http" out of: http, s3, init (init)
2024/08/21 16:28:14 [alert] 1#1: worker process 2 exited on signal 11 (core dumped)
2024/08/21 16:28:14 [alert] 1#1: worker process 3 exited on signal 11 (core dumped)
2024/08/21 16:28:15 [alert] 1#1: worker process 4 exited on signal 11 (core dumped)
2024/08/21 16:28:15 [alert] 1#1: worker process 5 exited on signal 11 (core dumped)
2024/08/21 16:28:28 [alert] 1#1: worker process 6 exited on signal 11 (core dumped)
2024/08/21 16:28:28 [alert] 1#1: worker process 7 exited on signal 11 (core dumped)
2024/08/21 16:28:59 [alert] 1#1: worker process 8 exited on signal 11 (core dumped)
2024/08/21 16:28:59 [alert] 1#1: worker process 9 exited on signal 11 (core dumped)

Good news is that I have a commit freezing nginx to a "good" version,
if you can give me rights to your fork I'll push it.

Possibly a bug with nginx, there were some segfault fixes in 1.25.4 release:
https://nginx.org/en/CHANGES
openresty/lua-nginx-module#2218

Signed-off-by: Alex Kalenyuk <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
Ensure the dependencies are up to date so we can
easily merge with s390x PRs in the future.

Signed-off-by: Alex Kalenyuk <[email protected]>
@akalenyu
Copy link
Collaborator

/test pull-cdi-unit-test

1 similar comment
@awels
Copy link
Member Author

awels commented Aug 21, 2024

/test pull-cdi-unit-test

@awels
Copy link
Member Author

awels commented Aug 21, 2024

/lgtm

@kubevirt-bot
Copy link
Contributor

@awels: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Collaborator

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-istio

@kubevirt-bot kubevirt-bot merged commit 43f4270 into kubevirt:main Aug 22, 2024
19 checks passed
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
* Rollback nginx from 1.24.0->1.22.1 to avoid segfaults when pulling https

Possibly a bug with nginx, there were some segfault fixes in 1.25.4 release:
https://nginx.org/en/CHANGES
openresty/lua-nginx-module#2218

Signed-off-by: Alex Kalenyuk <[email protected]>

* Run make rpm-deps to udpate dependencies for all arches

Ensure the dependencies are up to date so we can
easily merge with s390x PRs in the future.

Signed-off-by: Alex Kalenyuk <[email protected]>

---------

Signed-off-by: Alex Kalenyuk <[email protected]>
Co-authored-by: Alex Kalenyuk <[email protected]>
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
* Rollback nginx from 1.24.0->1.22.1 to avoid segfaults when pulling https

Possibly a bug with nginx, there were some segfault fixes in 1.25.4 release:
https://nginx.org/en/CHANGES
openresty/lua-nginx-module#2218

Signed-off-by: Alex Kalenyuk <[email protected]>

* Run make rpm-deps to udpate dependencies for all arches

Ensure the dependencies are up to date so we can
easily merge with s390x PRs in the future.

Signed-off-by: Alex Kalenyuk <[email protected]>

---------

Signed-off-by: Alex Kalenyuk <[email protected]>
Co-authored-by: Alex Kalenyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants