-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s390x rpm support #3286
s390x rpm support #3286
Conversation
Signed-off-by: cfillekes <[email protected]>
Hi @cfilleke. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Suggested Test:
But it doesn't check that these rpms are perfectly suited to the application. That would need to happen in the functional test of the fully built operator. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-containerized-data-importer-e2e-destructive |
@cfilleke: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-containerized-data-importer-e2e-destructive |
What this PR does / why we need it:
Add support for bazeldnf to maintain the rpm lists for s390x in BUILD.bazel
Add configurations necessary for bazeldnf to generate the rpm lists in WORKSPACE and BUILD.bazel, using the information for how to maintain these lists in .bazelrc, repo.yaml and hack/build/rpm-defs.sh as described in #3089 and #3090
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3202
Special notes for your reviewer:
Release note: