Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x rpm support #3286

Merged
merged 1 commit into from
May 26, 2024
Merged

s390x rpm support #3286

merged 1 commit into from
May 26, 2024

Conversation

cfilleke
Copy link
Member

What this PR does / why we need it:

Add support for bazeldnf to maintain the rpm lists for s390x in BUILD.bazel

Add configurations necessary for bazeldnf to generate the rpm lists in WORKSPACE and BUILD.bazel, using the information for how to maintain these lists in .bazelrc, repo.yaml and hack/build/rpm-defs.sh as described in #3089 and #3090

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3202

Special notes for your reviewer:

Release note:

kind/enhancement

Signed-off-by: cfillekes <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 22, 2024
@kubevirt-bot
Copy link
Contributor

Hi @cfilleke. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfilleke
Copy link
Member Author

@awels this is the same set of changes as PR #3203 but re-based, signed and merge conflicts resolved.

@cfilleke
Copy link
Member Author

cfilleke commented May 24, 2024

Suggested Test:

make rpm-deps will conduct a smoke test -- that the additions do not break the build and produce the expected result: rpm list updates in the WORKSPACE file, now with rpms for s390x architecture!

But it doesn't check that these rpms are perfectly suited to the application. That would need to happen in the functional test of the fully built operator.

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@cfilleke
Copy link
Member Author

/test pull-containerized-data-importer-e2e-destructive

@kubevirt-bot
Copy link
Contributor

@cfilleke: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-containerized-data-importer-e2e-destructive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-destructive

@kubevirt-bot kubevirt-bot merged commit 4a64af4 into kubevirt:main May 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide RPM support for s390x platform
4 participants