fix: patterns in expect script and adjust timeout/exit conditions #635
Conversation
kubevirt-bot
added
release-note-none
|
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@ksimon1 @jcanocan I've been encountering this error frequently in the CI logs: As far as I can tell, this issue is not related to my changes, as they only apply once the VM is ready. Are you experiencing any additional workload with your CI lately? |
nestoracunablanco
force-pushed
the
fix/expectExitCondition
branch
from
aa6f5da to
f751b15
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
The errors pertain to highperformance-large. I suspect they may have failed silently in the past, similar to the situation with ubuntu-tiny. To verify this assumption, I will disable the highperformance tests in Fedora and RHEL in this pull request before initiating a discussion, if necessary. |
The issue identified was that the string "1" is recognized as a pattern. The latest version of CentOS Stream 9 includes this "pattern" in its boot sequence. This commit also reveals some errors that failed silently, specifically related to highperformance configurations. For now, the plan is to disable these configurations and address the issues in a future pull request. Signed-off-by: Nestor Acuna Blanco <[email protected]>
nestoracunablanco
force-pushed
the
fix/expectExitCondition
branch
from
f751b15 to
cefd112
Compare
|
@0xFelix @ksimon1 @jcanocan I believe this demonstrates that the error was not due to a timeout issue. The root cause was that the high-performance tests were failing silently, and the expect script did not detect this earlier. |
There was a problem hiding this comment.
Agree with @nestoracunablanco, s390x should not be blocked by the issues with highperformance templates.
| @@ -62,7 +62,7 @@ spec: | |||
| EOF | |||
|
|
|||
| sizes=("tiny" "small" "medium" "large") | |||
| workloads=("desktop" "server" "highperformance") | |||
| workloads=("desktop" "server") | |||
There was a problem hiding this comment.
This will also disable highperformance tests for the Windows templates. Can you narrow it down to Fedora/RHEL?
There was a problem hiding this comment.
The Windows and Linux tests are located in separate files, so this should not disable the tests for Windows itself. For more details, please refer to this line
Thank you for your understanding regarding the high-performance issue!
|
@ksimon1, do you believe that the resolution of the conversation with Felix is sufficient for LGTM label? |
|
/lgtm |
The issue identified was that the string "1" is recognized as a pattern. The latest version of CentOS Stream 9 includes this "pattern" in its boot sequence.
What this PR does / why we need it: s390x enablement
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: