Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable efi bootloader in fedora for s390x #631

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: disable efi bootloader in fedora for s390x #631

merged 1 commit into from
Nov 6, 2024

Conversation

nestoracunablanco
Copy link
Contributor

Attempting to run it on other architectures (e.g., s390x) makes the image unbootable.

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@nestoracunablanco
fix: disable efi bootloader in fedora for s390x
9a1b42f 
Attempting to run it in this architecture makes the image
unbootable.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2024
0xFelix
0xFelix reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what impact this will have on arm64. IIRC arm64 requires efi?

@nestoracunablanco nestoracunablanco force-pushed the fix/fedoraBootloaders390x branch from d0969de to 9a1b42f Compare November 5, 2024 08:40
@nestoracunablanco nestoracunablanco changed the title fix: enable efi bootloader in fedora only for amd64 only fix: disable efi bootloader in fedora for s390x Nov 5, 2024
@nestoracunablanco
Copy link
Contributor Author

@0xFelix
Short answer: I’m not sure.
Long answer: For now, I can disable s390x. If we need to enable arm in the future, we can create another PR. What are your thoughts on this?

0xFelix
0xFelix reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

Sounds reasonable to me.

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@ksimon1
Copy link
Member

ksimon1 commented Nov 6, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
@kubevirt-bot kubevirt-bot merged commit 3759a79 into kubevirt:master Nov 6, 2024
18 checks passed
@nestoracunablanco nestoracunablanco deleted the fix/fedoraBootloaders390x branch November 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@akrejcir akrejcir Awaiting requested review from akrejcir

@fossedihelm fossedihelm Awaiting requested review from fossedihelm

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nestoracunablanco @kubevirt-bot @ksimon1 @0xFelix