Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin golang.org/x/text vendor to v0.3.3 #722

Merged
merged 1 commit into from
Jan 5, 2021
Merged

pin golang.org/x/text vendor to v0.3.3 #722

merged 1 commit into from
Jan 5, 2021

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jan 5, 2021

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

pin golang.org/x/text vendor to v0.3.3

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jan 5, 2021
phoracek
phoracek approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 5, 2021

/retest

1 similar comment
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 5, 2021

/retest

@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 5, 2021

/retest
known flaky

@kubevirt-bot kubevirt-bot merged commit 37fa390 into kubevirt:master Jan 5, 2021
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 6, 2021

/cherry-pick release-0.44

@kubevirt-bot kubevirt-bot mentioned this pull request Jan 6, 2021
Merged
@kubevirt-bot
Copy link
Collaborator

@RamLavi: new pull request created: #726

In response to this:

/cherry-pick release-0.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@qinqon qinqon Awaiting requested review from qinqon

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RamLavi @kubevirt-bot @phoracek